Skip to content

simulation scorer refactor #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 27, 2025
Merged

simulation scorer refactor #148

merged 12 commits into from
Aug 27, 2025

Conversation

frankyaoxiao
Copy link
Contributor

  1. Refactor simulation scoring implementation with better abstraction, documentation, and error handling. Regression tested against old implementation for speed and accuracy. Plug-and-play compatible with current API.
  2. Bump VLLM to latest (and v1 engine), re-enabling logprob-based simulation scoring
  3. Change default to prefer logprob-based scoring if using offline client in main

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SrGonao SrGonao merged commit 0ceaa10 into EleutherAI:main Aug 27, 2025
4 checks passed
@SrGonao SrGonao mentioned this pull request Aug 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankyaoxiao @CLAassistant @SrGonao