Skip to content

fix bug in EvalHarnessAdapter when pipe parallel size is set to 1 #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix bug in EvalHarnessAdapter when pipe parallel size is set to 1 #1356

wants to merge 1 commit into from

Conversation

MarisaJH
Copy link

resolves #1320

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentin-Anthony Quentin-Anthony Awaiting requested review from Quentin-Anthony Quentin-Anthony is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_forward_step_fn does not always return two values so eval.py breaks if is_pipe_parallel is false
2 participants
@MarisaJH @CLAassistant