Skip to content

Conversation

@xuhuanzy
Copy link
Member

@xuhuanzy xuhuanzy commented Dec 6, 2025

  1. 更改导出的默认行为, 现在如果是作为库/包文件解析, 则无法在主代码库内导入(报错), 必须要显式声明---@export global才能导出
  2. 新的路径占位符"${luarocks}"

添加 Default 导出作用域,根据配置文件处理默认导出
修改导出检查逻辑,默认情况下库文件不可见
完善导出标签解析,支持更多表达式类型
@gemini-code-assist
Copy link

Summary of Changes

Hello @xuhuanzy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a more flexible and context-aware system for handling export visibility in Lua code analysis. By adding a Default export scope, the system can now apply nuanced visibility rules, especially for modules that do not explicitly declare their export behavior. Additionally, the changes enhance the parsing of export tags within return statements, allowing for a broader range of Lua expression types to be correctly analyzed, leading to more precise semantic understanding.

Highlights

  • New Default Export Scope: Introduced a Default variant to the LuaExportScope enum, which will be used when no explicit export scope (like global or namespace) is specified for a module. This allows for configurable default behavior.
  • Enhanced Export Tag Analysis: Improved the analyze_export function to correctly identify the owner of an export tag within LuaReturnStat. It now supports NameExpr, ClosureExpr, and TableExpr, providing more accurate semantic analysis for returned values.
  • Refined Default Visibility Logic: Implemented a new check_default_export_visibility function. This function determines visibility for the new Default scope, treating modules identified as library files as not visible by default, while other files are considered visible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the @export functionality by extending its support on return statements to include named variables and closure expressions, not just table expressions. It also introduces a new Default export scope, which intelligently adjusts module visibility based on whether it's part of a library, making modules in libraries non-visible by default unless explicitly exported. This is a thoughtful improvement for better visibility control. The changes are consistent and well-implemented across the board. I have one minor suggestion to improve code conciseness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant