Skip to content

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Aug 30, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/runtests.jl b/test/runtests.jl
index 0827ba8..103db3a 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -75,7 +75,7 @@ Enzyme.API.printall!(true)
 
 @testset "Threads" begin
     cmd = `$(Base.julia_cmd()) --threads=1 --startup-file=no threads.jl`
-   	@test success(pipeline(cmd, stderr=stderr, stdout=stdout))
+    @test success(pipeline(cmd, stderr = stderr, stdout = stdout))
     cmd = `$(Base.julia_cmd()) --threads=2 --startup-file=no threads.jl`
-   	@test success(pipeline(cmd, stderr=stderr, stdout=stdout))
+    @test success(pipeline(cmd, stderr = stderr, stdout = stdout))
 end
diff --git a/test/threads.jl b/test/threads.jl
index 1fcb3b8..c69ebbf 100644
--- a/test/threads.jl
+++ b/test/threads.jl
@@ -22,5 +22,5 @@ using Test
         @inbounds x[i] *= x[i]
       end
     end
-    
+
 end

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2025

Benchmark Results

main 2271103... main / 2271103...
basics/overhead 6.17 ± 0.011 ns 5.25 ± 0.92 ns 1.18 ± 0.21
time_to_load 1.29 ± 0.03 s 1.28 ± 0.01 s 1.01 ± 0.025

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17349886255/artifacts/3890705955.

@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.74%. Comparing base (e31a84a) to head (2271103).
⚠️ Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (e31a84a) and HEAD (2271103). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (e31a84a) HEAD (2271103)
13 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2543       +/-   ##
===========================================
- Coverage   74.92%   31.74%   -43.19%     
===========================================
  Files          56       56               
  Lines       17428    17547      +119     
===========================================
- Hits        13058     5570     -7488     
- Misses       4370    11977     +7607     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy marked this pull request as draft August 30, 2025 12:35
@wsmoses
Copy link
Member Author

wsmoses commented Aug 30, 2025

@vchuravy @gbaraldi this looks like a bug in base julia?

specifically the assertion appears to occur outside of enzyme code?

@wsmoses wsmoses closed this Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants