-
Notifications
You must be signed in to change notification settings - Fork 109
Python plugin implementation #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@wbqpk3 Nice and large 😅 work, I will try to find some time to review it. Meanwhile please rebase it to |
|
@mcserep Rebased to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 40 out of 46 changed files in this pull request and generated 5 comments.
Files not reviewed (6)
- Config.cmake: Language not supported
- plugins/python/CMakeLists.txt: Language not supported
- plugins/python/model/CMakeLists.txt: Language not supported
- plugins/python/parser/.gitignore: Language not supported
- plugins/python/parser/CMakeLists.txt: Language not supported
- plugins/python/parser/requirements.txt: Language not supported
@wbqpk3 I just tried out this Copilot-based review feature of GitHub. The suggestions maybe worth a check, but feel free to ignore them in case they look unimportant. |
|
@wbqpk3 The CI fails for Ubuntu 20.04. While we should drop support for Ubuntu 20.04, it should still be checked why the build fails there.
|
UPDATE: CI jobs for Ubuntu 20.04 already started to skip, due to image unavailability. I have disabled the CI build for Ubuntu 20.04 in b9e6733, and added an issue #789 to deprecate it completely. Fixing this CI fail is not required. |
a55f31c to
2b1168a
Compare
This PR implements the Python plugin for CodeCompass.
Plugin components:
Parser:
pyparserwritten in Python, uses the Jedi static analysis library. Moreover,pyparseralso parses the Python AST in order to achieve better results.pyparsermodule gets loaded using the Python C APIPYNameService:
WebGUI:
Tests:
Documentation:
doc/pythonplugin.md.The missing part is the diagrams in the new WebGUI, however the diagrams component file needs some refactoring to use the new
language-serviceinstead ofCppService(similarly to #759).I think we should implement that in a separate PR.