Skip to content

Fix sprints page email and undefined title #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

egeakman
Copy link
Member

No description provided.

@europython-society
Copy link
Member

europython-society commented Jul 10, 2025

Preview available

Key Value
url https://fix-sprints.ep-preview.click
last update 2025-07-11T11:21:46.762Z

@egeakman egeakman requested review from nikoshell and hypha July 10, 2025 22:42
@hypha
Copy link
Contributor

hypha commented Jul 11, 2025

Thank you, Ege! The tab title part definitely lgtm! Will leave it to Marcin for the rest! (It does work on my computer XD)

Copy link
Contributor

@nikoshell nikoshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.tigerfinch.com/articles/spam-and-email-obfuscation/

https://www.reddit.com/r/cybersecurity/comments/z1xzs1/is_it_still_best_practice_to_obfuscate_email/

Those are two articles about this topic.

We spoke about it on the discord channel.
Better solution will be use other social handle,
or use solution like mozilla relay.

@egeakman
Copy link
Member Author

egeakman commented Jul 11, 2025

https://www.tigerfinch.com/articles/spam-and-email-obfuscation/

https://www.reddit.com/r/cybersecurity/comments/z1xzs1/is_it_still_best_practice_to_obfuscate_email/

Those are two articles about this topic.

We spoke about it on the discord channel.

Better solution will be use other social handle,

or use solution like mozilla relay.

This PR doesn't encourage obfuscation it just doesn't enforce for the input to be a valid [email protected] format. With this, people can choose whatever format they like, since they will be the ones getting the emails.

@nikoshell
Copy link
Contributor

https://www.tigerfinch.com/articles/spam-and-email-obfuscation/
https://www.reddit.com/r/cybersecurity/comments/z1xzs1/is_it_still_best_practice_to_obfuscate_email/
Those are two articles about this topic.
We spoke about it on the discord channel.
Better solution will be use other social handle,
or use solution like mozilla relay.

This PR doesn't encourage obfuscation it just doesn't enforce for the input to be a valid [email protected] format. With this, people can choose whatever format they like, since they will be the ones getting the emails.

We do exactly that, we expect that email is an email and we use mailto protocol for links after that, thats why we don't expect any security by obscurity.

@nikoshell
Copy link
Contributor

Why no one have issues those email?

image

@egeakman
Copy link
Member Author

https://www.tigerfinch.com/articles/spam-and-email-obfuscation/
https://www.reddit.com/r/cybersecurity/comments/z1xzs1/is_it_still_best_practice_to_obfuscate_email/
Those are two articles about this topic.
We spoke about it on the discord channel.
Better solution will be use other social handle,
or use solution like mozilla relay.

This PR doesn't encourage obfuscation it just doesn't enforce for the input to be a valid [email protected] format. With this, people can choose whatever format they like, since they will be the ones getting the emails.

We do exactly that, we expect that email is an email and we use mailto protocol for links after that, thats why we don't expect any security by obscurity.

I think this is mostly a matter of personal preference for the person entering their email, and I believe we should respect that. I'm totally fine with whatever direction you choose, so feel free to modify the PR!

@egeakman egeakman assigned nikoshell and unassigned egeakman Jul 11, 2025
@hypha
Copy link
Contributor

hypha commented Jul 11, 2025

Personally, I agree with Ege. I know my emails are all out there. I know that the obfuscation we were used to don't work in this day and age. But it also became a preference and habit. I don't mind it when that's not allowed. But it'd be also nice if it is 😊

Edit: forgot to say that ofc this is just a personal preference and not a strong way. Like Ege, happy to go either way.

@egeakman egeakman linked an issue Jul 11, 2025 that may be closed by this pull request
@nikoshell
Copy link
Contributor

Personally, I agree with Ege. I know my emails are all out there. I know that the obfuscation we were used to don't work in this day and age. But it also became a preference and habit. I don't mind it when that's not allowed. But it'd be also nice if it is 😊

Edit: forgot to say that ofc this is just a personal preference and not a strong way. Like Ege, happy to go either way.

No one force anyone to pass email, but if you provide email address we expect that it's email.
if someone like to "obfuscate" it can be added in the description.

Funny thing is that conversation comes from this PR
image

at the same time we can see his email everywhere else without any "obfuscation"

image image

Just to summarize, it's possible to add email which is obfuscated but in the description, we expect that email field is empty or it's email.

@egeakman egeakman closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprints page title is 'undefined'
4 participants