Skip to content

Conversation

D4N
Copy link
Member

@D4N D4N commented Sep 18, 2019

This should fix the build failures on CentOS that appeared today. Also, I bumped the version of the GitLab CI containers to use the latest tag where applicable.

clanmills
clanmills previously approved these changes Sep 19, 2019
Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with this, @D4N

I'm using import zlib in the test suite (for #989). Do we need an easy_install zlib or something like that? It won't show up immediately.

piponazo
piponazo previously approved these changes Sep 19, 2019
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although gitlab is failing in some cases ... are they random networking failures?

@clanmills
Copy link
Collaborator

It was CentOS that was giving trouble. "python3 not found" and I believe Dan changed that. I think he was installing a link from /usr/bin/python3 to /usr/bin/python36 or something like that. Now several platforms are complaining including Ubuntu.

This is rather frustrating. The CI is dictating progress. I still have several issues to fix for v0.27.3 and I'd like fixed issues integrated into v0.27-maintenance before dealing with the remaining open stuff. There's now almost no possibility of releasing 0.27.3 on schedule. On the other hand, there's nothing super urgent. Everything will settle soon.

@D4N
Copy link
Member Author

D4N commented Sep 19, 2019 via email

@D4N D4N force-pushed the bump_ci_containers branch from fd477c7 to a7d54d7 Compare September 30, 2019 10:22
@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #1002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   71.18%   71.18%           
=======================================
  Files         148      148           
  Lines       19418    19418           
=======================================
  Hits        13823    13823           
  Misses       5595     5595

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1125dcb...e22c97e. Read the comment docs.

@mergify mergify bot dismissed stale reviews from clanmills and piponazo September 30, 2019 10:22

Pull request has been modified.

D4N added 2 commits September 30, 2019 13:26
CentOS recently started to provide python3 by default obsoleted python36. Our
manual hack broke the test suite and is no longer required.
@D4N D4N force-pushed the bump_ci_containers branch from 582c781 to e22c97e Compare September 30, 2019 11:27
@D4N D4N merged commit 401e658 into master Sep 30, 2019
@mergify mergify bot mentioned this pull request Sep 30, 2019
@mergify mergify bot deleted the bump_ci_containers branch September 30, 2019 14:39
D4N added a commit that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants