Skip to content

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Apr 10, 2025

std::format is more efficient.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (2e6fb08) to head (065ae39).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/quicktimevideo.cpp 45.94% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   63.91%   63.89%   -0.03%     
==========================================
  Files         104      104              
  Lines       21752    21726      -26     
  Branches    10636    10639       +3     
==========================================
- Hits        13903    13881      -22     
+ Misses       5641     5637       -4     
  Partials     2208     2208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neheb neheb requested a review from kmilos April 19, 2025 20:00
std::format is more efficient.

Signed-off-by: Rosen Penev <[email protected]>
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit 40d63d1 into Exiv2:main Oct 6, 2025
93 of 94 checks passed
@neheb neheb deleted the un branch October 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants