-
Couldn't load subscription status.
- Fork 6
rewrite dispatcher system #5
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably update the readme to reflect these changes.
* Re-rewrite the listen_for decorator * Wrap stuff * Remove sentinental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Actually I'm unsure about the function names for listening to dispatched events After more thought I think I like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This rewrites the dispatcher system with more granular control over the events that are listened to without monkey patching.
Checklist
This PR makes changes to the code.
This PR makes changes to the documentation.
This PR has been tested.