Skip to content
This repository was archived by the owner on Aug 28, 2021. It is now read-only.

Conversation

@NCPlayz
Copy link
Member

@NCPlayz NCPlayz commented Oct 5, 2020

Description

This rewrites the dispatcher system with more granular control over the events that are listened to without monkey patching.

Checklist

  • This PR makes changes to the code.

    • The changes are breaking.
    • The changes implement a new feature.
    • The changes fix an issue.
    • I updated the documentation to reflect these changes.
  • This PR makes changes to the documentation.

    • The changes require a different version of sphinx.
    • I updated the configuration file to reflect these changes.
  • This PR has been tested.

@NCPlayz NCPlayz requested review from ShineyDev and bijij October 5, 2020 14:01
Gobot1234
Gobot1234 previously approved these changes Oct 6, 2020
Copy link
Contributor

@bijij bijij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably update the readme to reflect these changes.

* Re-rewrite the listen_for decorator

* Wrap stuff

* Remove sentinental
Copy link
Member

@ShineyDev ShineyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gobot1234
Copy link

Gobot1234 commented Dec 18, 2020

Actually I'm unsure about the function names for listening to dispatched events check_x doesn't really seem like a great name IMO.

After more thought I think I like dispatch_x much better

Copy link
Contributor

@bijij bijij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@sairam4123 sairam4123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants