refactor: change code review to output JSON for combine step #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the code review flow to output findings to a JSON file instead of posting inline comments directly. The combine step will then post all inline comments at once. Changes: - Updated review-prompt.ts to output findings to code-review-results.json - Updated droid-review.yml to use parallel workflow with prepare/review/combine - Updated tests to match new prompt format This enables parallel execution of code review with future security review, where the combine step will deduplicate and post all comments together. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the code review flow to output findings to a JSON file instead of posting inline comments directly. The combine step will then post all inline comments at once.
Changes
Review Prompt Changes
review-prompt.tsto output findings tocode-review-results.jsonWorkflow Changes
droid-review.ymlto use parallel workflow pattern:preparejob: Creates tracking commentcode-reviewjob: Runs review, outputs JSON, uploads artifactcombinejob: Downloads artifact, posts inline comments, updates summaryTest Updates
Why This Change?
This enables parallel execution of code review with future security review. The combine step will:
Depends On
Part of
This is PR 2 of 3 for the security review feature: