Skip to content

Conversation

@Anchel123
Copy link
Contributor

@Anchel123 Anchel123 commented Dec 8, 2025

…ordb, and bump falkordb version to 6.4.0

Summary by CodeRabbit

  • Chores
    • Improved server-side build handling to prevent bundling of server-only packages, reducing build/runtime issues.
    • Bumped a backend database dependency to v6.4.0.
    • Updated linting to ignore additional build/config files to reduce false positives during development.

✏️ Tip: You can customize this high-level summary in your review settings.

@Anchel123 Anchel123 requested a review from barakb December 8, 2025 11:39
@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
falkordb-browser Ready Ready Preview Comment Dec 11, 2025 5:40am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Walkthrough

ESLint now ignores next.config.js. The Next.js config externalizes falkordb for server builds to avoid bundling BigInt. The falkordb dependency is bumped from ^6.3.1 to ^6.4.0.

Changes

Cohort / File(s) Summary
ESLint config
\.eslintrc\.json
Added next.config.js to ignorePatterns.
Next.js build config
next.config.js
Added serverExternalPackages: ['falkordb'] under images/config and externalized falkordb as commonjs when isServer is true to keep it server-only and avoid bundling BigInt.
Dependencies
package.json
Bumped falkordb from ^6.3.1 to ^6.4.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify serverExternalPackages placement and Next.js version compatibility.
  • Confirm the webpack externalization runs only for server builds (isServer usage).
  • Quick check of falkordb@^6.4.0 release notes for breaking changes.

Poem

A lint rule skips a config file,
falkor stays where servers compile,
a minor bump, a tidy shift,
small changes make the build uplift. ✨

Suggested PR title: feat(build): externalize falkordb on server and ignore next.config.js in ESLint

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references fixing #1199 and mentions updating ESLint patterns and webpack configuration, which aligns with the actual changes (ESLint ignorePatterns and next.config.js serverExternalPackages), but is truncated and somewhat vague about the main objective of bumping falkordb to 6.4.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-falkordb-to-6.4.0

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dd4eed and 674f2b0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .eslintrc.json (1 hunks)
  • next.config.js (1 hunks)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Run TLS tests
  • GitHub Check: Run tests part 2 (except settings)
  • GitHub Check: Run token tests
🔇 Additional comments (3)
package.json (1)

61-61: Verify falkordb 6.4.0 is published/available where you install from.

The bump to ^6.4.0 looks fine, but public mirrors still list 6.3.1 as the latest right now. Please double‑check that 6.4.0 is published in the registry your CI and production use so npm install doesn’t start failing after this merges.

Suggested PR title (conventional commit style):
chore: bump falkordb to 6.4.0 and externalize server usage

.eslintrc.json (1)

33-35: Ignoring next.config.js in ESLint is reasonable here.

This keeps linting noise out for the JS config file while leaving the rest of the codebase covered. Just be aware that ESLint won’t catch issues inside next.config.js itself; rely on next build for validation there.

next.config.js (1)

8-9: Good use of serverExternalPackages to keep falkordb server-only.

This aligns with the current Next.js guidance for excluding Node‑specific deps from bundling. Two things to confirm:

  • next build runs cleanly without invalid-next-config warnings on your [email protected].
  • All falkordb imports live only in server code (Server Components, route handlers, API routes), not in use client components—serverExternalPackages doesn’t protect browser bundles.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Anchel123 Anchel123 changed the title Update ESLint ignore patterns, enhance webpack configuration for falk… Fix #1199 Update ESLint ignore patterns, enhance webpack configuration for falk… Dec 8, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb117f8 and 3f66136.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .eslintrc.json (1 hunks)
  • next.config.js (1 hunks)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Setup and cache dependencies
  • GitHub Check: build
🔇 Additional comments (2)
.eslintrc.json (1)

33-34: LGTM!

Adding next.config.js to the ignore patterns is appropriate, as configuration files often have looser typing requirements and don't benefit from strict TypeScript linting.

package.json (1)

61-61: falkordb version 6.4.0 is legitimate and has no known security vulnerabilities.

The version exists on npm as the latest release, is properly signed with valid integrity hashes, and published by the official FalkorDB maintainer. No security advisories or CVEs are publicly documented for this version.

@barakb
Copy link
Contributor

barakb commented Dec 9, 2025

@coderabbitai full review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

✅ Actions performed

Full review triggered.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1199 by updating the FalkorDB dependency to version 6.4.0 and modifying the build configuration to handle server-side rendering issues with the FalkorDB library. The changes also update ESLint configuration to exclude the Next.js config file from linting.

  • Updated FalkorDB dependency from version 6.3.1 to 6.4.0
  • Enhanced webpack configuration to externalize FalkorDB on the server-side to prevent BigInt bundling issues
  • Added next.config.js to ESLint ignore patterns

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Bumps falkordb dependency version to 6.4.0
next.config.js Adds server-side externalization for falkordb to resolve BigInt bundling issues
.eslintrc.json Excludes next.config.js from ESLint checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…e, preventing BigInt bundling issues. Add serverExternalPackages for falkordb in next.config.js.
@barakb
Copy link
Contributor

barakb commented Dec 11, 2025

@coderabbitai full review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

✅ Actions performed

Full review triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Browser] Bug: FalkorDB UI breaks, if it tries to render a node with a temporal data type (i.e. datetime)

3 participants