Skip to content

Conversation

@kineticneticat
Copy link
Contributor

Changes getNestedIota to check for subiotas rather than just for list iotas
Adds an interface to allow addons to handle iota replacement

Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor javadoc suggestion, but the code itself looks fine to me.

However, can you add a couple of unit tests? See here for an example of the setup required to instantiate iotas in a unit test (you'll need to merge or rebase onto the new commits from main):

companion object {
@BeforeAll
@JvmStatic
fun setUpOnce() {
// hack: we don't need bootstrap to succeed, we just need to set isBootstrapped so we can create registries
try {
Bootstrap.bootStrap()
} catch (_: Throwable) {}
HexIotaTypes.registerTypes { t, id -> Registry.register(HexIotaTypes.REGISTRY, id, t) }
}
}

@object-Object object-Object self-assigned this Oct 10, 2025
Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging without the unit tests so we can get this released.

@object-Object object-Object merged commit 3e05c5c into FallingColors:main Oct 10, 2025
15 of 16 checks passed
ChloeTax added a commit to ChloeTax/hexxy4 that referenced this pull request Oct 10, 2025
closes [#248](#248)
- Reenabled Phase Block.
- Fixed Phase Block not checking for edit permissions.
- Fixed a broken error message when attempting to use Phase Block on an unbreakable block.
- Merged Kinetic's PR to make the Everbook check for illegal iotas in subIotas instead of just in lists: [FallingColors/Hexal#159](FallingColors/Hexal#159)
- Merged Beholder's Everbook polishing PR: [FallingColors/Hexal#173](FallingColors/Hexal#173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants