Skip to content

Investigate allowing UTF8StreamJsonParser to be used without canonicalization (see #994) #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.16
Choose a base branch
from
Open

Investigate allowing UTF8StreamJsonParser to be used without canonicalization (see #994) #995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/fasterxml/jackson/core/json/ByteSourceJsonBootstrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,11 @@ public JsonParser constructParser(int parserFeatures, ObjectCodec codec,
if (enc == JsonEncoding.UTF8) {
/* and without canonicalization, byte-based approach is not performant; just use std UTF-8 reader
* (which is ok for larger input; not so hot for smaller; but this is not a common case)
* 5-May-2023, ckozak [core#994]: The reader-based implementation under-performs for small inputs
* due to the initialization cost of InputStreamReader which allocates a new 8KiB buffer. Normalizing
* benchmarks for that fixed cost, ReaderBasedJsonParser maintains a performance edge in tested scenarios.
* Notes from this investigation can be found here:
* https://github.com/FasterXML/jackson-core/pull/995#issuecomment-1523912770
*/
if (JsonFactory.Feature.CANONICALIZE_FIELD_NAMES.enabledIn(factoryFeatures)) {
ByteQuadsCanonicalizer can = rootByteSymbols.makeChild(factoryFeatures);
Expand Down