Potential fix for #5184 (Record ignoral) #5419
Draft
+58
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
added
the
gen-ai
Member
|
This PR seems to be meant #5184 ? 4 and 8 are flipped :) @cowtowncoder |
Member
Author
|
Thank you @JooHyukKim -- you are right. FIxed. :) |
cowtowncoder
changed the title
cowtowncoder
commented
Nov 26, 2025
| // @JsonIgnore that would conflict with record component properties. | ||
| // For example, a record with component "value" should not have its property ignored | ||
| // just because there's a non-accessor method "getValue()" marked with @JsonIgnore. | ||
| if (ignore && isRecordType() && !_forSerialization && !nameExplicit) { |
Member
Author
There was a problem hiding this comment.
This might be ok but...
cowtowncoder
commented
Nov 26, 2025
| // just because there's a non-accessor method "getValue()" marked with @JsonIgnore. | ||
| if (ignore && isRecordType() && !_forSerialization && !nameExplicit) { | ||
| // Only skip if this is NOT the actual record accessor method | ||
| if (_accessorNaming instanceof DefaultAccessorNamingStrategy.RecordNaming) { |
Member
Author
There was a problem hiding this comment.
This gets into too much special casing; need to have better knowledge of "true" Record properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #5184: not really loving all special-casing but might help figure out cleaner fix.