Skip to content

[Jackson-3] Add new DeserializationProblemHandler.handleNullForPrimitives() #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JooHyukKim wants to merge 12 commits into
base: 3.x
Choose a base branch
from
Open

[Jackson-3] Add new DeserializationProblemHandler.handleNullForPrimitives() #5493

JooHyukKim wants to merge 12 commits into from
+198 −6

Conversation

@JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Dec 10, 2025 •
edited
Loading

fix #5469

Target branch TBD

@JooHyukKim JooHyukKim changed the base branch from 3.x to 3.0 December 10, 2025 15:17
@JooHyukKim JooHyukKim changed the title fix #5469 Add new DeserializationProblemHandler.handleNullForPrimitives() Dec 10, 2025
@JooHyukKim JooHyukKim changed the title Add new DeserializationProblemHandler.handleNullForPrimitives() [Jackson-3] Add new DeserializationProblemHandler.handleNullForPrimitives() Dec 10, 2025
pjfanning
pjfanning reviewed Dec 10, 2025
View reviewed changes
pjfanning
pjfanning reviewed Dec 10, 2025
View reviewed changes
@JooHyukKim
Copy link
Member Author

JooHyukKim commented Dec 10, 2025

Thank you @pjfanning !

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 10, 2025

API change, needs to go in 3.x (for 3.1.0), not patch.

cowtowncoder
cowtowncoder reviewed Dec 11, 2025
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting very close to good! Just added a couple of notes.

And also: needs to target 3.x, not 3.0, as per my earlier comment.

@JooHyukKim JooHyukKim changed the base branch from 3.0 to 3.x December 13, 2025 09:13
@JooHyukKim
Copy link
Member Author

JooHyukKim commented Dec 13, 2025

Thanksss,

  1. Applied review
  2. Changed target branch to 3.x

@github-actions
Copy link

github-actions bot commented Dec 13, 2025

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 78.8% 📈 +0.100%
Branches branches 72.5% 📈 +0.000%

Coverage data generated from JaCoCo test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder left review comments

@pjfanning pjfanning pjfanning left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add callback to signal null for primitive in DeserializationProblemHandler

3 participants

@JooHyukKim @cowtowncoder @pjfanning