[Jackson-3] Add new DeserializationProblemHandler.handleNullForPrimitives()
#5493
Conversation
JooHyukKim
changed the title
DeserializationProblemHandler.handleNullForPrimitives()
JooHyukKim
changed the title
DeserializationProblemHandler.handleNullForPrimitives()DeserializationProblemHandler.handleNullForPrimitives()
src/main/java/tools/jackson/databind/DeserializationContext.java
Outdated
Show resolved
Hide resolved
src/main/java/tools/jackson/databind/DeserializationContext.java
Outdated
Show resolved
Hide resolved
|
Thank you @pjfanning ! |
|
API change, needs to go in 3.x (for 3.1.0), not patch. |
src/main/java/tools/jackson/databind/deser/DeserializationProblemHandler.java
Show resolved
Hide resolved
| if (_isCompatible(targetClass, instance)) { | ||
| return instance; | ||
| } | ||
| return reportInputMismatch(deser, msg); |
There was a problem hiding this comment.
Since this is problem with handler providing incompatible value, needs to use specific failure message and NOT generic "no nulls for primitives".
There was a problem hiding this comment.
Modified exception thrown AND added test about this case also
| } | ||
| // In case our problem handler providing incompatible value, | ||
| throw new InvalidFormatException(_parser, | ||
| String.format("Cannot deserialize value of type %s from type %s", |
There was a problem hiding this comment.
This is better, but might be confusing as it does not identify handler as the source of failure: caller might assume core Jackson is doing something funny. So should indicate it is a registered DeserializationProblemHandler that provided bad value.
I think some existing handler processing methods show examples.
| throw new InvalidFormatException(_parser, | ||
| String.format("Cannot deserialize value of type %s from type %s", | ||
| targetClass, ClassUtil.getClassDescription(instance)), | ||
| instance, targetClass |
There was a problem hiding this comment.
Instead of plain targetClass, use method from ClassUtil, I think nameOf(Class<?>).
Handles nulls and surrounds with backtick (plus I think deals with array class types).
3 participants
fix #5469
Target branch TBD