Fix record serialization when using JacksonAnnotationExtension #207
Conversation
TomaszGaweda
changed the title
| if (orig != null) { | ||
| newProp = APropBuilder.merge(orig, newProp); | ||
| } | ||
| ((IndexedMap<String, APropBuilder>) _props) |
There was a problem hiding this comment.
rationale: we don't want to change position, because of the renaming
|
Hi @cowtowncoder, I'd very appreciate if you could take a look at this PR (of course nothing urgent). Thanks in advance! |
|
@TomaszGaweda sorry for delay, hoping to review this week (having to focus on 3.0.0-rc10 first). Just thought I'll add a note to let you know this is on my radar, todo list. |
|
Thanks a lot @cowtowncoder for the update and no worries :) |
jr-annotation-support/src/main/java/com/fasterxml/jackson/jr/annotationsupport/IndexedMap.java
Show resolved
Hide resolved
…introspection' into fix-records-with-annotationbasedintrospection
jr-annotation-support/src/main/java/com/fasterxml/jackson/jr/annotationsupport/IndexedMap.java
Outdated
Show resolved
Hide resolved
| Object value = prop.getReader().readNext(r, p); | ||
| values[prop.getIndex()] = value; | ||
| } | ||
| for (int i = 0; i < values.length; i++) { |
There was a problem hiding this comment.
This would require a comment -- explaining that for primitive types nulls not allowed.
| } | ||
| for (int i = 0; i < values.length; i++) { | ||
| if (values[i] == null) { | ||
| for (BeanPropertyReader prop : _propsByName.values()) { |
There was a problem hiding this comment.
This is rather inefficient with n*n complexity (although I guess mostly n if no nulls from missing entries?). Would be good to have either direct lookup (ordered array/List of props by index), or...
actually better idea, I think -- for records, pre-created Object[] with defaults for primitive values.
Then something like:
final Object[] values = Arrays.copyOf(preset, preset.length);
and avoid post-scanning?
jr-objects/src/main/java/com/fasterxml/jackson/jr/ob/impl/BeanReader.java
Show resolved
Hide resolved
2 participants
This PR fixes record serialization and deserialization when using Java Records with JacksonAnnotationExtension
Fixes #176