Skip to content

Refactor RuntimeStatistics to make it more extendable for future counters #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor RuntimeStatistics to make it more extendable for future counters #8747

wants to merge 1 commit into from

Conversation

dyemanov
Copy link
Member

  • Improve bounds checking (make it compile-time using class enum)
  • Simplify retrieval of the counters (using operator[])
  • Make it easier to extend internally, especially adding grouped counters (per-tablespace page I/O counters, temp I/O counters, etc)

@dyemanov dyemanov self-assigned this Sep 21, 2025
asfernandes
asfernandes reviewed Sep 22, 2025
View reviewed changes
src/jrd/RuntimeStatistics.h
// Runtime statistics class
// Runtime statistics

enum class PageStatType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these two enuns be int-based or could use a underlying smaller type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't store it anywhere and it's always passed through stack, I think the default int is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asfernandes asfernandes asfernandes left review comments

Assignees

@dyemanov dyemanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyemanov @asfernandes