Develop

[sungchaewon]

이슈 번호

작업 내용

기타

Summary by CodeRabbit

• New Features
  • S3 파일 업로드를 위한 presigned URL과 파일 접근 URL을 함께 제공하는 기능이 추가되었습니다.
• Bug Fixes
  • 프로필 및 기본 이미지의 기본 URL이 S3 버킷의 영구 이미지로 변경되어 이미지 표시가 안정적으로 개선되었습니다.
• Chores
  • S3 관련 API 엔드포인트(/api/s3/**)에 대한 인증 없이 접근이 가능하도록 보안 설정이 업데이트되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

S3 presigned URL 생성 및 반환 로직이 개선되어, 업로드용 presigned URL과 파일 접근 URL을 함께 반환하는 DTO가 도입되었습니다. S3 관련 API 엔드포인트의 인증이 완화되었고, 기본 프로필 이미지 URL이 S3 버킷으로 일괄 변경되었습니다.

Changes

파일/경로	변경 요약
.../config/SecurityConfig.java	/api/s3/** 경로에 대해 인증 없이 접근 허용 추가
.../controller/MypageMemberController.java	프로필 presigned URL 생성 로직을 generatePresignedUploadUrl 단일 호출 및 DTO 반환 방식으로 변경
.../dto/s3/PresignedUploadResponseDto.java	presigned URL과 파일 URL을 담는 DTO 클래스 신규 추가
.../service/S3Service.java	presigned URL 생성 메서드의 이름 및 반환 타입을 DTO로 변경
.../service/MainPageService.java .../service/PostService.java	기본 이미지 URL을 S3 버킷 URL로 변경
.../util/DefaultImage.java	기본 프로필 이미지 상수 값을 S3 버킷 URL로 변경

Sequence Diagram(s)

sequenceDiagram
    participant Controller as MypageMemberController
    participant Service as S3Service
    participant DTO as PresignedUploadResponseDto

    Controller->>Service: generatePresignedUploadUrl(dirName, filename, minutes)
    Service->>DTO: PresignedUploadResponseDto(presignedUrl, fileUrl)
    Service-->>Controller: PresignedUploadResponseDto
    Controller->>Client: presignedUrl, fileUrl 포함 응답 반환

Loading

Suggested labels

chaewon

Suggested reviewers

• semsemin

Poem

🐇
새 프로필 사진 올릴 때,
presigned URL 한 번에 받아오네!
기본 이미지도 S3로 쏙,
보안 경로도 넓어졌네, 폭!
FixLog의 변화, 토끼도 춤춰요,
깡총깡총, 새로워진 코드에 박수 쳐요!
🥕

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 10030fd and 4a37e6b.

📒 Files selected for processing (7)

• src/main/java/com/example/FixLog/config/SecurityConfig.java (1 hunks)
• src/main/java/com/example/FixLog/controller/MypageMemberController.java (3 hunks)
• src/main/java/com/example/FixLog/dto/s3/PresignedUploadResponseDto.java (1 hunks)
• src/main/java/com/example/FixLog/service/MainPageService.java (1 hunks)
• src/main/java/com/example/FixLog/service/PostService.java (1 hunks)
• src/main/java/com/example/FixLog/service/S3Service.java (3 hunks)
• src/main/java/com/example/FixLog/util/DefaultImage.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.