Fix compatibility issue with FixedEffectModels.jl v1.11 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compatibility issue with FixedEffectModels.jl v1.11 by updating the CI configuration.
- The minimum supported Julia version is updated from 1.6 to 1.9.
- The cache action is updated from actions/cache@v1 to actions/cache@v4.
Files not reviewed (2)
- src/fit.jl: Language not supported
- src/utils/formula.jl: Language not supported
| matrix: | ||
| version: | ||
| - '1.6' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'. | ||
| - '1.9' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'. |
There was a problem hiding this comment.
The inline comment still references Julia 1.5 as the minimum version. Please update the comment to accurately reflect that the new minimum supported version is 1.9.
Suggested change
| - '1.9' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'. | |
| - '1.9' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.9 or higher, change this to '1.9'. |
Member
|
Thanks a lot! I just took care of it in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing this package. It's a nice surprise that when I wanted to implement something there has already been a pretty well written package out there.
This PR is to fix the issue that there is an API change in FixedEffectModels.jl in v1.11, which regife is not supported