Skip to content

fix(iOS): Handle NSNull in iosCustomBrowser param for logout #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(iOS): Handle NSNull in iosCustomBrowser param for logout #1070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-native-app-auth/ios/RNAppAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,13 @@ - (void)endSessionWithConfiguration: (OIDServiceConfiguration *) configuration
#if TARGET_OS_MACCATALYST
id<OIDExternalUserAgent> externalUserAgent = nil;
#elif TARGET_OS_IOS
id<OIDExternalUserAgent> externalUserAgent = iosCustomBrowser != nil ? [self getCustomBrowser: iosCustomBrowser] : [self getExternalUserAgentWithPresentingViewController:presentingViewController
prefersEphemeralSession:prefersEphemeralSession];
id<OIDExternalUserAgent> externalUserAgent;
if (iosCustomBrowser != nil && ![iosCustomBrowser isEqual:[NSNull null]]) {
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting the null/NSNull check for iosCustomBrowser into a helper method to improve code readability and reuse.

Suggested change
if (iosCustomBrowser != nil && ![iosCustomBrowser isEqual:[NSNull null]]) {
if ([self isNonNullObject:iosCustomBrowser]) {

Copilot uses AI. Check for mistakes.

externalUserAgent = [self getCustomBrowser:iosCustomBrowser];
} else {
externalUserAgent = [self getExternalUserAgentWithPresentingViewController:presentingViewController
prefersEphemeralSession:prefersEphemeralSession];
}
#endif

_currentSession = [OIDAuthorizationService presentEndSessionRequest: endSessionRequest
Expand Down