Move core types from phlex::experimental to phlex namespace
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (76.36%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 76.27% 76.36% +0.08%
==========================================
Files 124 124
Lines 2748 2733 -15
Branches 476 475 -1
==========================================
- Hits 2096 2087 -9
+ Misses 454 449 -5
+ Partials 198 197 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Migrate public API types from the experimental namespace to the main phlex namespace while keeping implementation details in experimental. This makes the public interface cleaner and signals API stability. Types moved to phlex namespace: - configuration: Configuration management for algorithms and modules - concurrency: Concurrency control (unlimited/serial/user-specified) - data_cell_index and data_cell_index_ptr: Data hierarchy navigation - product_query and product_queries: Product specification - handle: Type-safe product handles with data cell context - framework_driver: Async driver for framework execution - operator""_in: User-defined literal for defining product queries Types remaining in phlex::experimental: - framework_graph: Core graph execution engine - layer_generator: Test utility for creating data layer hierarchies - product_specification, algorithm_name: Internal naming/identification - All detail namespace implementations - Node templates - Test support utilities (products_for_output, etc.) Updated all test files and plugins to use correct namespace qualifications: - Changed 'using namespace phlex::experimental' to 'using namespace phlex' where appropriate - Qualified experimental types (e.g., experimental::framework_graph) - Updated module registration macros to use phlex::configuration This change maintains backward compatibility for internal code while establishing a clearer boundary between public API and implementation details.
knoepfel
force-pushed
the
namespace-migration
branch
from
085fd17 to
d3a866d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates public API types from the
phlex::experimentalnamespace to the mainphlexnamespace while keeping implementation details inphlex::experimental.Types moved to
phlexnamespace:configuration: Configuration management for algorithms and modulesconcurrency: Concurrency control (unlimited/serial/user-specified)data_cell_indexanddata_cell_index_ptr: Data hierarchy navigationproduct_queryandproduct_queries: Product specificationhandle: Type-safe product handles with data cell contextframework_driver: Async driver for framework executionoperator""_in: User-defined literal for defining product queriesFacilities remaining in
phlex::experimental:framework_graph: Core graph execution enginelayer_generator: Test utility for creating data layer hierarchiesproduct_specificationandalgorithm_name: Internal naming/identificationdetailnamespace implementationsproducts_for_output, etc.)when(...)filtering clause member function has been renamedexperimental_when(...)Updated all test files and plugins to use correct namespace qualifications:
using namespace phlex::experimentaltousing namespace phlexwhere appropriateexperimental::framework_graph)Closes #105.