Clarify text formatting standard to eliminate ambiguity #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the text formatting standard to explicitly state that the final line must be non-empty and terminated with a single linefeed, leaving no trailing blank lines. This clarification addresses potential ambiguity in the previous wording. Co-authored-by: greenc-FNAL <[email protected]>
Copilot
AI
changed the title
[WIP] Clarify instructions based on feedback from review
Clarify text formatting standard to eliminate ambiguity
Jan 6, 2026
greenc-FNAL
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies the text formatting standard in the Copilot instructions to remove ambiguity about file endings. The original wording could be misinterpreted as requiring a blank line at the end of files, when the intent was to require that the last content line be terminated with a newline character.
- Updated the text formatting standard to explicitly state that the final line must be non-empty and terminated with a newline character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text formatting instruction "All text files must end with exactly one newline character and no trailing blank lines" was ambiguous and could be interpreted as requiring a blank line at the end of files.
Changes
.github/copilot-instructions.mdto explicitly state: "All text files must have their final line be non-empty and terminated with a single newline character (linefeed), leaving no trailing blank lines"This clarifies that files should end with content-bearing lines terminated by
\n, not blank lines.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.