Fix: Large fast forward/rewind value popup on player #8236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
PikachuEXE
reviewed
Nov 6, 2025
Collaborator
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Try it locally first
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
…layer.js Co-authored-by: PikachuEXE <[email protected]>
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 7, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
PikachuEXE
approved these changes
Nov 8, 2025
absidue
approved these changes
Nov 8, 2025
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #8230
Description
Rounds
formattedSecondsto two decimal places to avoid a very long displayed valueScreenshots
Testing
Go to Player settings
Set Video Playback Rate Interval to 0.1
Set Fast-Forward / Rewind Interval to 13s
Set the playback speed to 1.8x
Watch a video
Use ←, →, J and L
See playback rate popup showing rounded number