Add button to open live chat popup in browser #8278
Conversation
github-actions
bot
added
the
PR: waiting for review
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Please remove the nesting, as it doesn't play well with Vue's scoped styles causing styles to "leak" into other components. In all the plain CSS files we've done it properly without nesting, the only reason that some SCSS files have nesting is because it is technical debt that we haven't cleaned up yet.
TODO for myself: Check if there is a stylelint rule we can use to enforce no-nesting with the linters.
| <button | ||
| class="popoutChatButton" | ||
| :title="$t('Video.Popout Live Chat')" | ||
| @click="popoutChat" | ||
| > | ||
| <FontAwesomeIcon | ||
| class="popoutChatIcon" | ||
| :icon="['fas', 'fa-arrow-up-right-from-square']" | ||
| /> | ||
| </button> |
There was a problem hiding this comment.
Please use a link instead of a button, as it is a link and using a button bypasses the external link handling setting.
There was a problem hiding this comment.
Nesting seems to be resolved but this isnt yet
There was a problem hiding this comment.
I've been too busy to address this, but hopefully in a week or so can get to it. Just to confirm, it should be a regular <a> html link?
There was a problem hiding this comment.
I've been too busy to address this, but hopefully in a week or so can get to it. Just to confirm, it should be a regular
<a>html link?
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Head branch was pushed to by a user without write access
3 participants
Pull Request Type
Related issue
closes #1721
Description
Adds a button that opens a new browser window with the current video live chat
Screenshots
Testing
Go to a video that is listed as "Live"
Click on the "Popout chat" button
See that the current video live chat is opened in a new browser window
Additional context
h4label was replaced withspanbecause of margin was stretching button hover animationthe margin is now applied to the container, replicating the same size as before but the height is ~10px less now