V2 Coins with static witness predicates #960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
changed the title
MitchTurner
force-pushed
the
feature/v2-chargeable-tx-coin
branch
from
d046b44 to
fd4a8dc
Compare
Dentosal
reviewed
Jun 11, 2025
version-compatibility/src/fuel_tx.rs
Outdated
| // Given | ||
| let tx_pointer = fuel_tx_0_59_1::TxPointer::new(1u32.into(), idx); | ||
| let expected = latest_fuel_tx::TxPointer::new(1u32.into(), idx.into()); | ||
| let expected = latest_fuel_tx::TxPointer::new(1u32.into(), idx); |
Member
There was a problem hiding this comment.
Removal of the .into() here breaks the code, as the type changes based on feature-flags.
Dentosal
reviewed
Jun 11, 2025
| #[tokio::test] | ||
| async fn script_v2__estimate_predicate__fails_if_predicate_data_not_found_in_static_witnesses() | ||
| { | ||
| todo!() |
Member
There was a problem hiding this comment.
Is this intentionally left as todo!?
Member
Author
There was a problem hiding this comment.
No. I just forgot to add this case. Thanks.
Dentosal
approved these changes
Sep 29, 2025
Dentosal
requested changes
Sep 29, 2025
Member
Dentosal
left a comment
Dentosal
left a comment
There was a problem hiding this comment.
The above-mentioned test is still todo!()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #955
(followup to #948)
This PR is tackling the bulk of the new "multi-input predicate" model, where a predicate coin will point to a "static witness" on the transaction rather than having the code directly on the input. This allows multiple inputs to share the same predicate and predicate data bytes as well as share the same execution, i.e. if two inputs point at the same predicate and predicate data, that predicate will only be run once!
This will enable in a vast improvement in performance for predicates that need to iterate over all the inputs, moving from
O(N^2)toO(N)in those specific cases. We needed to move this to the newChargeableTransationV2to avoid old predicates from being abused by the new feature.Checklist