[ENHANCEMENT] Chart Editor - Modify individual events in selection #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Lasercar
changed the title
Lasercar
force-pushed
the
enhancement/chart-editor-modify-individual-events-in-selection
branch
2 times, most recently
from
04ee186 to
46b2eda
Compare
Lasercar
force-pushed
the
enhancement/chart-editor-modify-individual-events-in-selection
branch
from
46b2eda to
01101d0
Compare
|
Hmm, maybe I should add a dummy value? (So you can add new events without effecting the current selection) Edit: Did it anyway! |
Hundrec
added
the
topic: chart editor
|
Well that's... definitely a way to be able to stack events and being able to edit them at once |
3 tasks
Also adds a no selected event item, so new events with different values can be added without changing an existing event.
Lasercar
force-pushed
the
enhancement/chart-editor-modify-individual-events-in-selection
branch
from
7e56499 to
0de0089
Compare
Lasercar
changed the title
Hundrec
added
the
topic: changes assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #4192, fixes #5109, fixes #5028
Description
This PR adds a dropdown of the currently selected events to the event data toolbox, allowing you to modify the data of the selected events separately.
It also adds an option to enable the previous functionality (editing the entire event selection at the same time), but modifies it slightly to only apply to events of the same type. Selecting a event kind with the option enabled will set the entire selection to that type, however.
Also adds support for unknown events (aka, psycho users who can't be bothered to make events properly in mod ports to new FNF).
Important
Requires FunkinCrew/funkin.assets#195
If anyone can figure out why the selectedIndex of the dropdown doesn't get set when set I'd appreciate it.
Screenshots/Videos
2025-05-22.22-19-52.mp4
Unknown events support:
