[ENHANCEMENT] Fixed BPM changes for Monster #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
type: charting issue
3 tasks
AbnormalPoof
force-pushed
the
develop
branch
5 times, most recently
from
e0ba6ab to
bcd30e1
Compare
AbnormalPoof
added
status: needs revision
|
oh, sorry. these prs haven't exactly been top priority for me lately |
|
ok, i think i've figured out how to do a rebase properly edit: looks good to me |
Hundrec
added
status: pending triage
|
Will you please merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
FunkinCrew/Funkin#5256
Description
This PR restores the original BPM changes for this song from the Week 7 update, replacing the current ones that put everything out of sync.
It's not a direct port, though: the game's original BPM change system was section-based, so the changes had to be manually ported over to the current system (which is millisecond-based), with some liberties taken to ensure maximum accuracy.
With this fix, the notes and the grid are within a millisecond of being perfectly aligned throughout the song.
Screenshots/Videos
Before
After