[BUGFIX] Fix Chart Editor Crash When Selecting a Theme More Than Once #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: major bug
|
This also fixes a bug where having the current theme as Dark would display both Light and Dark as selected in the dropdown menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes FunkinCrew/Funkin#6178
Description
When selecting a theme more than once in the chart editor, the game would crash. Let me tell you this. It specifically has to do with the Dark theme and not Light. I'm not entirely sure why this crashes, but judging by the crash log for the issue listed above, the problem likely has to do with HaxeUI.
Screenshots/Videos
fix.chart.theme.select.crash.mp4