Fix Windows file deletion issue in test_dict_flattening.py #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves PermissionError on Windows during temporary directory cleanup by restoring the original working directory before the TemporaryDirectory context manager exits. On Windows, you cannot delete a directory that is the current working directory. The tests were calling os.chdir(tmpdir) and then attempting to clean up the directory when the context exited, causing: - PermissionError: [WinError 32] The process cannot access the file because it is being used by another process - PermissionError: [WinError 5] Access is denied Solution: Wrap test logic in try/finally blocks that save and restore the original working directory, allowing Windows to successfully delete temporary directories during cleanup. Fixes #40 (Windows CI failure in test_dict_flattening.py)
yannrichet-asnr
pushed a commit
that referenced
this pull request
Nov 22, 2025
Apply test_dict_flattening.py from PR #46 which includes: - Windows file deletion fix (try/finally blocks) - Pandas availability check (try/except import) - pytestmark to skip tests when pandas unavailable This ensures compatibility with environments where pandas may not be installed while maintaining the Windows file cleanup fix.
Resolved conflicts in tests/test_dict_flattening.py by: - Removing PANDAS_AVAILABLE checks (pandas is now required) - Keeping Windows file deletion fixes with os.getcwd()/os.chdir() pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PermissionError on Windows during temporary directory cleanup by restoring the original working directory before the TemporaryDirectory context manager exits.
On Windows, you cannot delete a directory that is the current working directory. The tests were calling os.chdir(tmpdir) and then attempting to clean up the directory when the context exited, causing:
Solution: Wrap test logic in try/finally blocks that save and restore the original working directory, allowing Windows to successfully delete temporary directories during cleanup.
Fixes #40 (Windows CI failure in test_dict_flattening.py)