-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Revise Logger portability through modules
#144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I added a suggested pre-commit hook script. I find it easier to check that all linter and formatters pass. That the doc compiled too. If you think this deserves a PR on its own, I can adjust |
RomainBaville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have done a great job, it seems easier to maintain and limite the code duplication.
geos-processing/src/geos/processing/generic_processing_tools/FillPartialArrays.py
Show resolved
Hide resolved
|
Looks good to me ! |
jafranc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'll proceed changing other files 👍
This PR aims at revising the
Loggerand logging portability between VTK filters and their paraview plugins counterparts (in geos-pv). It plans to:Extend under first round approval the decorator to all plugins--- New arch---
Based on
VTKHandlerexample,GEOSHandlerto have access toemitlogic and formatGEOSFomatterwith aTrimColorfuncion to help passing bash color tag free string to vtk inner logicgetLoggerbut withpropagate=Trueto stick to originalloggingclass train of thoughts and allow file handler too. Might be replace bylogging.getLoggersoon, if proper refactor and encapsulation of logger init is done.The addition does not need an "adding function" type of decorator, just to decorate the handler removal step in the PV plugin initializer. Then removal of previous
detailshelpers ingeos-utilsand appening toLoggermoduleThis will includes all PV plugins with exceptions:
PVGeosBlockExtractMerge.py,PVMohrCirclePlot.pyfor now as they have a more complex structure and did not directly fit this PR but can be treated in a forthcoming onePVPythonViewConfigurator.pyandPVGeosLogReader.pyas they do not fit this refactor