-
Notifications
You must be signed in to change notification settings - Fork 2
v12: Remove support for mom5 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This is one of a set of PRs to remove support for MOM5 in GEOSgcm v12. There are PRs in: * GEOSgcm: * GEOS_OceanGridComp: * GEOSgcm_App:
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
1 similar comment
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
@mfmehari From the CI, I guess this means we need an update to mom6 as well right? For the new |
This might not be the best place to ask this but I see lot of relevant folks are tagged here. @amolod and I are wondering if there are any difference between v11 and v12 for the AOIL module, the answer is most likely no but wouldn't hurt to ask: https://github.com/GEOS-ESM/GMAO_Shared/blob/main/GEOS_Shared/atmOceanIntLayer.F90 |
Connections for dual-ocean in MOM6 are set, further updates need to be done in the other GCs for dual ocean to work ... |
You may check it here (GEOS-ESM/GEOSgcm@v11.7.1...GCMv12-rc16). I do not see changes in atmOceanIntLayer.F90 file between v11.7.1 and GCMv12-rc16. |
Thanks @sinakhani, is GCMv12-rc16 the version you recommend me testing with? In other words with land mask and vertical mixing changes? |
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
This is one of a set of PRs to remove support for MOM5 in GEOSgcm v12. There are PRs in:
geos/v3.7
This will need updates for Dual Ocean support so we keep draft for now. The needed changes are in GEOS_OceanGridComp and in mom6.
At the moment there is the commented MOM5 dual ocean code in the MOM6 plug. We will work with @mfmehari and @atrayano and @sinakhani to get this in. This will need a put routine that @mfmehari has already created for his OBIO work.
ETA: Also, I believe @Dooruk needs dual ocean as well for his work!