v12: add v14 bcs and update topo path #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pre/remap_restart/remap_questions.py # pre/remap_restart/remap_utils.py
mathomp4
added
the
0 diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v12 equivalent of #156 from @biljanaorescanin which adds support for v14 BCs. Per that PR:
However, it's a bit more complex because, I think, of changes from #144 found in testing.
The issue was I tried to remap from some (saved) MERRA-2 restarts to v14. But in doing so, the end results only had a
saltwater_internal_rstfile and not the expected splitopenwaterandseaicethermorestarts. So this PR also has changes that says "If my inputs havesaltwaterthen we split and only preserve theopenwaterandseaicethermo.Also, in consultation with @biljanaorescanin we remove all references to v13 BCs and make v12 BCs the default until we (eventually) move to v14.