-
Notifications
You must be signed in to change notification settings - Fork 3
additional modifications in fvsetup for more integrated land-atmosphere DAS setup and configuration #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@gmao-rreichle changes here corresponding to ldasGC pr#94 draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraqzhang, please double-check my edits in the most recent commit 03c1dda.
Also see inline comments below.
|
updates are tested in setup of a hybrid4dnvar LADAS ( with ldas_setup updated in ldasGC PR#94) |
|
@gmao-rreichle update command line inputs corresponding to ldasGC PR#94. For the path info of ldas SPEC NML and MWRTM param, the options of default and user input to fvsetup are also added. |
|
@gmao-rreichle c2a59da deal with atm_ens input with "later " option for atmens ICS installation |
@saraqzhang : Thanks for adding this. I edited the query text a bit and fixed an error in the variable name (I think) d4480d0. I also updated the branch to the latest develop. Please double check. |
|
yes that was a typo. d4480d0 fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my approval was too early. Need to create a new GEOSldas_GridComp release and update the components.yaml file accordingly. Will do ASAP
MAPL v2.57 includes the ExtData fix of v2.56.1 and the EASE Grid Factory needed by GEOSldas_GridComp
|
@gmao-rreichle @rtodling the current system ( v5.42.11 + PR#352 ) passed tests of built, LADAS setup and 2-day hybrid cycling run. a tag is created LADAS_v5.42.11 . |
|
Is the change in MAPL a zero-diff change? |
Between MAPL v2.52 and v2.57, there is no mention about non-zero-diff. So it should be zero-diff |
Yes, it's 0-diff. @rtodling, aren't you already using MAPL v2.56.1 (which includes the ExtData fix) in your branch? v2.57.0 only changes EASE-grid routines, which is 0-diff (and the EASE grid isn't used by ADAS anyway). But as @weiyuan-jiang said, MAPL should be 0-diff between v2.52 and v2.57 |
Additional modifications of fvsetup for more integrated land-atm DAS setup and configuration (on top of #327).
Contingent on: