Skip to content

Conversation

@saraqzhang
Copy link
Contributor

@saraqzhang saraqzhang commented May 1, 2025

Additional modifications of fvsetup for more integrated land-atm DAS setup and configuration (on top of #327).

Contingent on:

@saraqzhang saraqzhang added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label May 1, 2025
@saraqzhang saraqzhang requested a review from a team as a code owner May 1, 2025 16:06
@saraqzhang saraqzhang requested review from gmao-rreichle and removed request for a team May 1, 2025 16:10
@saraqzhang
Copy link
Contributor Author

@gmao-rreichle changes here corresponding to ldasGC pr#94 draft.

@gmao-rreichle gmao-rreichle changed the title modifications in fvsetup corresponding to ldasGC pr #94 additional modifications in fvsetup corresponding on top of GEOSadas PR#327 May 2, 2025
@gmao-rreichle gmao-rreichle changed the title additional modifications in fvsetup corresponding on top of GEOSadas PR#327 additional modifications in fvsetup on top of GEOSadas PR#327 May 2, 2025
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saraqzhang, please double-check my edits in the most recent commit 03c1dda.
Also see inline comments below.

@gmao-rreichle gmao-rreichle changed the base branch from feature/saraqzhang/updatesetup4ladas to develop May 5, 2025 18:45
@gmao-rreichle gmao-rreichle marked this pull request as draft May 5, 2025 18:45
@gmao-rreichle gmao-rreichle changed the title additional modifications in fvsetup on top of GEOSadas PR#327 additional modifications in fvsetup for more integrated land-atmosphere DAS setup and configuration May 5, 2025
@gmao-rreichle gmao-rreichle added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs enhancement New feature or request and removed 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels May 5, 2025
@saraqzhang
Copy link
Contributor Author

updates are tested in setup of a hybrid4dnvar LADAS ( with ldas_setup updated in ldasGC PR#94)

@saraqzhang
Copy link
Contributor Author

@gmao-rreichle update command line inputs corresponding to ldasGC PR#94. For the path info of ldas SPEC NML and MWRTM param, the options of default and user input to fvsetup are also added.

@saraqzhang
Copy link
Contributor Author

@gmao-rreichle c2a59da deal with atm_ens input with "later " option for atmens ICS installation

@gmao-rreichle
Copy link
Contributor

@gmao-rreichle c2a59da deal with atm_ens input with "later " option for atmens ICS installation

@saraqzhang : Thanks for adding this. I edited the query text a bit and fixed an error in the variable name (I think) d4480d0. I also updated the branch to the latest develop. Please double check.

@gmao-rreichle gmao-rreichle removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jun 9, 2025
@saraqzhang
Copy link
Contributor Author

yes that was a typo. d4480d0 fixed it.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review June 17, 2025 17:33
gmao-rreichle
gmao-rreichle previously approved these changes Jun 17, 2025
gmao-rreichle
gmao-rreichle previously approved these changes Jun 17, 2025
@gmao-rreichle gmao-rreichle marked this pull request as draft June 17, 2025 17:43
@gmao-rreichle gmao-rreichle marked this pull request as draft June 17, 2025 17:43
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my approval was too early. Need to create a new GEOSldas_GridComp release and update the components.yaml file accordingly. Will do ASAP

MAPL v2.57 includes the ExtData fix of v2.56.1 and the EASE Grid Factory needed by GEOSldas_GridComp
@saraqzhang
Copy link
Contributor Author

@gmao-rreichle @rtodling the current system ( v5.42.11 + PR#352 ) passed tests of built, LADAS setup and 2-day hybrid cycling run. a tag is created LADAS_v5.42.11 .

@gmao-rreichle gmao-rreichle marked this pull request as ready for review July 1, 2025 13:11
@rtodling
Copy link
Collaborator

Is the change in MAPL a zero-diff change?

@weiyuan-jiang
Copy link

Is the change in MAPL a zero-diff change?

Between MAPL v2.52 and v2.57, there is no mention about non-zero-diff. So it should be zero-diff

@gmao-rreichle
Copy link
Contributor

Is the change in MAPL a zero-diff change?

Between MAPL v2.52 and v2.57, there is no mention about non-zero-diff. So it should be zero-diff

Yes, it's 0-diff. @rtodling, aren't you already using MAPL v2.56.1 (which includes the ExtData fix) in your branch? v2.57.0 only changes EASE-grid routines, which is 0-diff (and the EASE grid isn't used by ADAS anyway). But as @weiyuan-jiang said, MAPL should be 0-diff between v2.52 and v2.57

@gmao-rreichle gmao-rreichle requested review from weiyuan-jiang and removed request for weiyuan-jiang August 7, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants