-
Notifications
You must be signed in to change notification settings - Fork 4
High density BUFR radiosonde code from NCEP #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
radiosonde data.
of uprair data.
read_obs.F90 - remove redundant code for READ_UPRAIR
|
See GEOS-ESM/NCEP_Shared#33 for the revised bufr library |
|
Meta, could you add jmccurry95 for this PR? Thanks. |
|
Adding @jmccurry95 (hope it works) |
fixed conflicts
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement |
|
I'm never sure how to mark situations like this. If the uprair files are assimilated the results will be zero diff. If they are not read in, I suspect these changes will be zero-diff. I put non-zero-diff but it could go either way. |
Without other permissions I think I need to comment on the issue to be an assignee, so you should be able to add me now |
I agree with @gmao-msienkie here. When a new feature introduces non-zero diffs, zero-diff is the feature is not exercised, that to me is typically a zero-diff change. Now, if by touching nothing in the default settings, the code changes produces non-zero diffs, then the changes should be marked as non-zero diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should know that changes in gmao_global_convinfo introduced here are not enough. These changes need to be put in the convinfo database.
The above means that the changes in this PR must be contingent on changes to the db:
Yes, I was reminded of that when working on a merge with develop. I am working on the changes in the GEOS_mksi and started a branch with the same name there. I had started working on this code/branch with a checkout of GEOSadas-5.30.3 last year so there are some things lagging a bit. I need to get a newer tag checked out and pull my changes over since there are some other repositories that will have corresponding changes - e.g. obsys-nccs.rc when we establish a location for the 'uprair' files, the BUFR library change, possibly some others. |
|
Also, Josh is testing and modifying the settings of these observation errors. He will submit another set of changes soon. |
Resolved conflict in setupq.f90
Copied code from NCEP GSI used for assimilating 'uprair' BUFR files containing high density radiosondes from BUFR reports on the GTS.
Includes a bug fix from Josh for the vertical intepolation of HDraob observation error.
Use of this code requires BUFR library to be compiled with dynamic allocation. There is a branch in NCEP_Shared with changes for the bufrlib dynamic allocation and also a few updates to the code.