Skip to content

Conversation

@gmao-msienkie
Copy link
Contributor

Copied code from NCEP GSI used for assimilating 'uprair' BUFR files containing high density radiosondes from BUFR reports on the GTS.
Includes a bug fix from Josh for the vertical intepolation of HDraob observation error.
Use of this code requires BUFR library to be compiled with dynamic allocation. There is a branch in NCEP_Shared with changes for the bufrlib dynamic allocation and also a few updates to the code.

@gmao-msienkie gmao-msienkie added the enhancement New feature or request label Feb 26, 2025
@gmao-msienkie gmao-msienkie requested review from a team as code owners February 26, 2025 20:56
@gmao-msienkie
Copy link
Contributor Author

See GEOS-ESM/NCEP_Shared#33 for the revised bufr library

@gmao-yzhu
Copy link
Contributor

Meta, could you add jmccurry95 for this PR? Thanks.

@gmao-msienkie
Copy link
Contributor Author

gmao-msienkie commented Feb 27, 2025

Adding @jmccurry95 (hope it works)
Nope, it won't let me add him as an assignee.

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement

@gmao-msienkie gmao-msienkie added the Non 0-diff The changes in this pull request are non-zero-diff label Mar 1, 2025
@gmao-msienkie
Copy link
Contributor Author

I'm never sure how to mark situations like this. If the uprair files are assimilated the results will be zero diff. If they are not read in, I suspect these changes will be zero-diff. I put non-zero-diff but it could go either way.

@jmccurry95
Copy link

jmccurry95 commented Mar 3, 2025

Adding @jmccurry95 (hope it works) Nope, it won't let me add him as an assignee.

Without other permissions I think I need to comment on the issue to be an assignee, so you should be able to add me now

@rtodling
Copy link
Contributor

I'm never sure how to mark situations like this. If the uprair files are assimilated the results will be zero diff. If they are not read in, I suspect these changes will be zero-diff. I put non-zero-diff but it could go either way.

I agree with @gmao-msienkie here. When a new feature introduces non-zero diffs, zero-diff is the feature is not exercised, that to me is typically a zero-diff change.

Now, if by touching nothing in the default settings, the code changes produces non-zero diffs, then the changes should be marked as non-zero diff.

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should know that changes in gmao_global_convinfo introduced here are not enough. These changes need to be put in the convinfo database.

The above means that the changes in this PR must be contingent on changes to the db:

https://github.com/GEOS-ESM/GEOS_mksi

@gmao-msienkie
Copy link
Contributor Author

gmao-msienkie commented Mar 11, 2025

You should know that changes in gmao_global_convinfo introduced here are not enough. These changes need to be put in the convinfo database.

The above means that the changes in this PR must be contingent on changes to the db:

https://github.com/GEOS-ESM/GEOS_mksi

Yes, I was reminded of that when working on a merge with develop. I am working on the changes in the GEOS_mksi and started a branch with the same name there.

I had started working on this code/branch with a checkout of GEOSadas-5.30.3 last year so there are some things lagging a bit. I need to get a newer tag checked out and pull my changes over since there are some other repositories that will have corresponding changes - e.g. obsys-nccs.rc when we establish a location for the 'uprair' files, the BUFR library change, possibly some others.

@gmao-yzhu
Copy link
Contributor

Also, Josh is testing and modifying the settings of these observation errors. He will submit another set of changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants