gcm_setup python conversion #602
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshakoor1
added
0 diff
sshakoor1
removed
the
0 diff
mathomp4
reviewed
Apr 10, 2024
Co-authored-by: Matthew Thompson <[email protected]>
…iments are trivial zero diff
tclune
reviewed
Jan 8, 2025
tclune
reviewed
Jan 8, 2025
| @@ -0,0 +1,67 @@ | |||
| import os, sys, platform | |||
There was a problem hiding this comment.
"utility" is a bit vague. Possibly a more specific name could be thought of?
There was a problem hiding this comment.
Yes I agree. Env and utility should probably be merged into a new script down the line. These scripts were kind of thrown together early on and desperately need to be updated.
added 2 commits
April 10, 2025 11:19
# Conflicts: # AGCM.rc.tmpl # HISTORY.AGCM.rc.tmpl # HISTORY.AOGCM-MOM5.rc.tmpl # HISTORY.AOGCM.rc.tmpl # fvcore_layout.rc # gcm_forecast.tmpl # gcm_regress.j # gcm_run.j # gcm_setup # linkbcs.tmpl
# Conflicts: # gcm_forecast.tmpl # gcm_regress.j # gcm_run.j # gcm_setup
sshakoor1
force-pushed
the
feature/sshakoor/gcmpy
branch
from
2e225fa to
d02a7db
Compare
mathomp4
removed
the
0 diff trivial
# Conflicts: # AGCM.rc.tmpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fully rewrite gcm_setup in python, as a small start of a larger effort to refactor the GEOS codebase.
Some notes:
gcm_v12which is future of the gcm, not the currentdevelopbranch (https://github.com/GEOS-ESM/GEOSgcm_App/tree/feature/sdrabenh/gcm_v12).gcm_setuphas been uncharacteristically edited/expanded upon quite a bit this past year, so a lot of features have yet to be added (e.g. singularity sandbox, etc.). In addition, some parts of the code may be outdated from the latest commit of the mainline script.gcm_setupthat previously had the syntax@foonow look like{{ foo }}.ml python/GEOSpyDto load the latest version on discover).~/GEOSgcm/install/bin/gcmpy/scripts/and run the commandpython gcm_setup.py