Skip to content

add v14 bcs and change topo path #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: feature/sdrabenh/gcm_v12
Choose a base branch
from
Open

add v14 bcs and change topo path #767

wants to merge 4 commits into from
+113 −19

Conversation

@biljanaorescanin
Copy link
Contributor

This PR does two things:

  1. Adds support for new bcs v14 set , this is currently under testing for default GCM v12 candidate
  2. Change how we link and where we source topo files , change to more version controlled topo files

It was tested for AMIP at c48 with v14.

this is example from run log:
'/discover/nobackup/projects/gmao/bcs_shared/make_bcs_inputs/atmosphere/TOPO/v2/CF0048x6C/smoothed/gwd_internal_rst' -> 'gwd_internal_rst'

@biljanaorescanin biljanaorescanin added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Sep 18, 2025
@biljanaorescanin biljanaorescanin marked this pull request as ready for review October 22, 2025 17:44
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner October 22, 2025 17:44
@mathomp4
Copy link
Member

mathomp4 commented Oct 22, 2025 •
edited
Loading

I think I know why the CI is failing here. I probably need to update my TinyBCs. I'll try and get that working...

ETA: I'm marking draft until I can fix up the TinyBCs...

@mathomp4 mathomp4 marked this pull request as draft October 22, 2025 21:51
@mathomp4 mathomp4 marked this pull request as ready for review October 23, 2025 17:17
@biljanaorescanin
Copy link
Contributor Author

Testing summary:

  1. PR was tested for 1 day AMIP, REPLAY and IncREPLAY and all were zero diff for v12 BCs where baseline is GCMv12-rc20 and exp is only this PR change.
  2. Regression testing done by @mathomp4 was a PASS.
  3. v14 functionality worked
    This PR is ready for you @sdrabenh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mathomp4 mathomp4

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biljanaorescanin @mathomp4