Optimization of aerosol callback #1082
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation fuses the loops over modes and thereby significantly reduces memory copies. It also potentially reduces memory storage, as the AeroProps data structure is not needed. (At least here.)
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
|
Tagging @aoloso who will likely be called upon to test these changes. |
|
@tclune looks good. The deleted code however is needed for the 2 moment microphysics. Although if we are doing something like this, it is probably better to call the callback from MGB making a copy there, and forget about the structure all together. Old code like RAS and MG1 would need to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation fuses the loops over modes and thereby
significantly reduces memory copies. It also potentially reduces
memory storage, as the AeroProps data structure is not needed. (At
least here.)
@wmputman
@dbarahon