Skip to content

Conversation

weiyuan-jiang
Copy link
Contributor

@YujiN, I am trying to bring back some codes in develop branch. The develop branch is not working as it is but I believe it would be more efficient. The runoff and the other variables are distributed as needed, which is way more efficient than allgatherV.

Yujin Zeng and others added 30 commits October 23, 2024 21:22
…t in GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSroute_GridComp
@weiyuan-jiang weiyuan-jiang added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 14, 2025
@weiyuan-jiang weiyuan-jiang changed the title changes refactoring river-routing Sep 9, 2025
@weiyuan-jiang
Copy link
Contributor Author

weiyuan-jiang commented Sep 9, 2025

@zyj8881357 and @gmao-rreichle , I have made some changes:

  1. Added a new catchment space which can be used in Internal ( restart) and History output. https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/3bf435f7614657329592c60f8b75509656e353a1/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSroute_GridComp/GEOS_RouteGridComp.F90#L722C5-L722C65

  2. Added mapping from tile space to catchment space . https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/3bf435f7614657329592c60f8b75509656e353a1/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSroute_GridComp/GEOS_RouteGridComp.F90#L724C5-L724C67. It can be used here
    , which would replace the codes

  3. Added subroutine to exchange downstream.

    . It is zero-diff and quite efficient. It exchanges about 4 or 5 values each processor instead of 300K. It would be used
    here
    and replace the codes

4)Also all the outputs ( including check balance) and restarts will be replaced by the simple codes like this

@weiyuan-jiang
Copy link
Contributor Author

To make further changes, we should start with make_bcs to produce necessary files

@weiyuan-jiang
Copy link
Contributor Author

@zyj8881357 , I think this PR is ready for the test and comparison. To run this branch, you will need the develop branch of GEOSldas and feature/wjiang/pfaf_index of MAPL. Also please take a look at my run example in /discover/nobackup/wjiang/LDAS_exp/model/Routing
You will need three files : route_internal_rst, tile_pfaf.nc4 and river_input.nc
Please diff my LDAS.rc with yours and change yours accordingly to run the program. The route_internal_rst is not the same as yours. I am using the second day's restart (20140102 000000). You can create your own restart.

@gmao-rreichle
Copy link
Contributor

cc @gmao-rreichle

@weiyuan-jiang weiyuan-jiang changed the base branch from feature/yujinz/Routing_GEOSroute to develop September 25, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants