Skip to content

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jun 23, 2025

Revised and simplified processing of HISTORY template (GEOSldas_HIST.rc).
The revised HISTORY file provides examples for additional 2d HISTORY output.
When running a simulation in EASE grid tile space, 2d latlon-gridded outputs is now possible.
When running a simulation in cubed-sphere tile space, 2d EASE grid output is now possible.

Successfully 0-diff tested by @gmao-rreichle after 1ed3029

New functionality (2d output from EASE tile space and 2d output on EASE grid) verified by @gmao-rreichle

@weiyuan-jiang
Copy link
Contributor Author

Verification of the outputs is needed

@gmao-rreichle
Copy link
Collaborator

@weiyuan-jiang : I tried to simplify and clean up the processing of the HIST rc template in this commit 65abe5e

Unfortunately, this required touching ldas_setup again, although it's probably not too difficult to port the changes into #107 once the present PR has been finalized and merged. Sorry about that!

I did not 0-diff test the PR, nor did I test its implied new functionality (i.e., output EASE simulations on a 2d lat/lon grid).

Because I eliminated the "ASSIM" flag of process_hist.csh, it's possible my changes break the assim tests, depending on whether Matt's tests have a fixed HISTORY rc file or rely on the HISTORY.rc file produced by ldas_setup. We can fix this later if needed. If so, my preference is to update the test config files (i.e., add HISTORY.rc files to the tests if they don't have it now), rather than edit the source code again.

For now, please take a look at my changes and let me know if you see any obvious errors or issues. Thanks!

@weiyuan-jiang
Copy link
Contributor Author

@weiyuan-jiang : I tried to simplify and clean up the processing of the HIST rc template in this commit 65abe5e

Unfortunately, this required touching ldas_setup again, although it's probably not too difficult to port the changes into #107 once the present PR has been finalized and merged. Sorry about that!

I did not 0-diff test the PR, nor did I test its implied new functionality (i.e., output EASE simulations on a 2d lat/lon grid).

Because I eliminated the "ASSIM" flag of process_hist.csh, it's possible my changes break the assim tests, depending on whether Matt's tests have a fixed HISTORY rc file or rely on the HISTORY.rc file produced by ldas_setup. We can fix this later if needed. If so, my preference is to update the test config files (i.e., add HISTORY.rc files to the tests if they don't have it now), rather than edit the source code again.

For now, please take a look at my changes and let me know if you see any obvious errors or issues. Thanks!

It looks right. But I will need to run the ldas_setup and compare the output. Are you going to remove 'SMAP_L4_SM_gph' for all simulation?

@gmao-rreichle
Copy link
Collaborator

It looks right. But I will need to run the ldas_setup and compare the output. Are you going to remove 'SMAP_L4_SM_gph' for all simulation?

The idea is to have the same pre-defined collections as before, including 'SMAP_L4_SM_gph', although the latter always remains turned off when the HISTORY rc file is produced by ldas_setup from the GEOSldas_HIST.rc template. The user can easily edit the resulting HISTORY file and turn on the 'gph' collection if desired.

More generally, it's impossible to isolate the user completely from editing HISTORY.rc, and it makes little sense to write 'gph' when GEOSldas does assimilation and 'lnd' otherwise (which is the current behavior).

Now that EASE tile space can be regridded to lat/lon via MAPL, we no longer need to restrict the options like we did before. Generally, I still think a simulation on the EASE tile space should write output in tile space. But there's nothing wrong with offering the 2d lat/lon output as an option. (Previously, uncommenting the 2d output for an EASE tile space would have resulted in garbage.)

@gmao-rreichle gmao-rreichle changed the title added more 2D outputs to sample HISTORY.rc Revised processing of HISTORY template (GEOSldas_HIST.rc) Jun 25, 2025
@gmao-rreichle gmao-rreichle marked this pull request as ready for review June 25, 2025 16:42
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner June 25, 2025 16:42
@gmao-rreichle gmao-rreichle merged commit 0df22b1 into develop Jun 25, 2025
18 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/add_regrided_output branch June 25, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants