-
Notifications
You must be signed in to change notification settings - Fork 0
Revised processing of HISTORY template (GEOSldas_HIST.rc) #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Verification of the outputs is needed |
|
@weiyuan-jiang : I tried to simplify and clean up the processing of the HIST rc template in this commit 65abe5e Unfortunately, this required touching I did not 0-diff test the PR, nor did I test its implied new functionality (i.e., output EASE simulations on a 2d lat/lon grid). Because I eliminated the "ASSIM" flag of process_hist.csh, it's possible my changes break the assim tests, depending on whether Matt's tests have a fixed HISTORY rc file or rely on the HISTORY.rc file produced by ldas_setup. We can fix this later if needed. If so, my preference is to update the test config files (i.e., add HISTORY.rc files to the tests if they don't have it now), rather than edit the source code again. For now, please take a look at my changes and let me know if you see any obvious errors or issues. Thanks! |
It looks right. But I will need to run the ldas_setup and compare the output. Are you going to remove 'SMAP_L4_SM_gph' for all simulation? |
The idea is to have the same pre-defined collections as before, including 'SMAP_L4_SM_gph', although the latter always remains turned off when the HISTORY rc file is produced by ldas_setup from the GEOSldas_HIST.rc template. The user can easily edit the resulting HISTORY file and turn on the 'gph' collection if desired. More generally, it's impossible to isolate the user completely from editing HISTORY.rc, and it makes little sense to write 'gph' when GEOSldas does assimilation and 'lnd' otherwise (which is the current behavior). Now that EASE tile space can be regridded to lat/lon via MAPL, we no longer need to restrict the options like we did before. Generally, I still think a simulation on the EASE tile space should write output in tile space. But there's nothing wrong with offering the 2d lat/lon output as an option. (Previously, uncommenting the 2d output for an EASE tile space would have resulted in garbage.) |
Revised and simplified processing of HISTORY template (GEOSldas_HIST.rc).
The revised HISTORY file provides examples for additional 2d HISTORY output.
When running a simulation in EASE grid tile space, 2d latlon-gridded outputs is now possible.
When running a simulation in cubed-sphere tile space, 2d EASE grid output is now possible.
Successfully 0-diff tested by @gmao-rreichle after 1ed3029
New functionality (2d output from EASE tile space and 2d output on EASE grid) verified by @gmao-rreichle