fix: matrix load tests

[HendrikLeuschner]

Pull Request Checklist

• 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
  have been resolved.
• 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
  [Unreleased] heading.
• 3. I have documented my code using JDocs tags.
• 4. I have removed unnecessary commented out code, imports and System.out.println statements.
• 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
• 6. I have created API tests for any new functionality exposed to the API.
• 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
  along with a short description of what it is for, and documented this in the Pull Request (below).
• 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
• 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
• 10. For new features or changes involving building of graphs, I have tested on a larger dataset
  (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
• 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
  importer etc.), I have generated longer distance routes for the affected profiles with different options
  (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
  points generated from the current live ORS.
  If there are differences then the reasoning for these MUST be documented in the pull request.
• 12. I have written in the Pull Request information about the changes made including their intended usage
  and why the change was needed.
• 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes matrix load testing.

Information about the changes

• Key functionality added: Properly run the matrix load tests.
• Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

[Copilot]

Pull Request Overview

This pull request fixes matrix load testing by refactoring the test classes and the matrix API request creation logic, along with improving configuration handling and enhancing error messages.

• Updated test cases for matrix request body creation and coordinate/integer parsing
• Refactored MatrixAlgorithmLoadTest and related API endpoints to use MatrixModes instead of DirectionsModes
• Added overloads and documentation updates to streamline error handling and internal configuration

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
MatrixAlgorithmLoadTestTest.java	Added comprehensive tests to cover request body creation and input parsing scenarios
BenchmarkEnumsTest.java	Extended tests for new MatrixModes conversion and parameter retrieval
RequestBodyCreationException.java	Added an additional constructor to support single parameter exceptions
MatrixAlgorithmLoadTest.java	Refactored methods to parse CSV inputs and create matrix API requests using MatrixModes
Config.java	Updated to include separate configuration for matrixModes, though an error exists in its implementation
BenchmarkEnums.java	Added MatrixModes enum with dedicated request parameters and profiles

Comments suppressed due to low confidence (1)

ors-benchmark/src/main/java/org/heigit/ors/benchmark/Config.java:159

• The getMatrixModes method incorrectly processes the 'directionsModes' property instead of using the 'matrixModes' property. Update the stream to use 'matrixModes.stream()' to ensure the correct mode configuration is applied.

                : directionsModes.stream().map(MatrixModes::fromString).toList();

[Copilot]

The error message in MatrixModes.fromString refers to 'directions mode' instead of 'matrix mode'. Consider updating it to 'Invalid matrix mode: ' to better reflect the context.

Suggested change

	default -> throw new IllegalArgumentException("Invalid directions mode: " + value);
	default -> throw new IllegalArgumentException("Invalid matrix mode: " + value);

[aoles]

Thanks! 👍

Please consider addressing the two issues reported by SonarQube, and the one by Copilot. Cheers!

[HendrikLeuschner]

Addressed all comments

[Copilot]

Pull Request Overview

This pull request fixes matrix load testing by introducing new tests and updating the implementation to use MatrixModes. Key changes include:

• Adding comprehensive tests for matrix load request body creation and error handling.
• Updating load test logic and configuration to use MatrixModes instead of DirectionsModes.
• Enhancing BenchmarkEnums with a new MatrixModes enum and accompanying request parameter methods.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ors-benchmark/src/test/java/org/heigit/ors/benchmark/MatrixAlgorithmLoadTestTest.java	Added tests covering valid and error scenarios for matrix load request bodies.
ors-benchmark/src/test/java/org/heigit/ors/benchmark/BenchmarkEnumsTest.java	Added tests for the MatrixModes enum functionality.
ors-benchmark/src/main/java/org/heigit/ors/benchmark/exceptions/RequestBodyCreationException.java	Added an overloaded constructor to support exception messages.
ors-benchmark/src/main/java/org/heigit/ors/benchmark/MatrixAlgorithmLoadTest.java	Updated load test logic and request body creation to support MatrixModes.
ors-benchmark/src/main/java/org/heigit/ors/benchmark/Config.java	Updated configuration to parse and support new matrix mode settings.
ors-benchmark/src/main/java/org/heigit/ors/benchmark/BenchmarkEnums.java	Introduced MatrixModes with associated request parameters and profile retrieval.

Comments suppressed due to low confidence (1)

ors-benchmark/src/main/java/org/heigit/ors/benchmark/BenchmarkEnums.java:98

• The getProfiles() method for MatrixModes returns only 'driving-car', but tests expect additional profiles (e.g., 'foot-walking') and a total of 4 profiles. Consider updating getProfiles() to return the complete set of expected profiles.

return switch (this) { case ALGO_DIJKSTRA_MATRIX, ALGO_CORE_MATRIX, ALGO_RPHAST_MATRIX -> List.of("driving-car");//, "driving-hgv", "cycling-regular", "foot-walking"); };

[aoles]

Thanks a lot for addressing the issues pointed out in my previous review 👍

Changes from the recent commits raised a few new SonarQube issues, plus a seemingly valid comment from Copilot. Would you mind looking into these? Cheers! ❤️

[HendrikLeuschner]

Fixed sonarqube issues. What copilot mentioned I fixed as well, but I opted to go for vehicle-car benchmarking for now only.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud