Dev-Docs #11 Capitalize Partner Portal, lowercase portal #583
Conversation
ajfarkas
requested review from
Jeremy1026,
h-m-m,
mmagsa,
nickttng and
nprimak
| The <a target="_blank" href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/form-action">CSP form-action</a> directive restricts which URLs can be used as the target of form submissions from a given context. Certain Chromium-based internet browsers (e.g. Google Chrome and Microsoft Edge) enforce the form-action directive through the entire redirect chain (if any). Other non-Chromium-based browsers only check the first redirect in the chain (e.g. Firefox). For Chromium-based browsers, upon form submission, any attempts to redirect to a url not explicitly listed as a form-action source will violate the CSP directive and cause a failure to load and a console error. | ||
| <br/><br/> | ||
| This error occurs when Service Providers attempt to redirect users to a url that is not registered in the Redirect URLs field in the <a target="_blank" href="https://dashboard.int.identitysandbox.gov/">Login.gov Portal</a> application's configuration. All urls that users could be redirected to, even as a passthrough, need to be included in the list of Redirect URLs. | ||
| This error occurs when Service Providers attempt to redirect users to a url that is not registered in the Redirect URLs field in the <a target="_blank" href="https://dashboard.int.identitysandbox.gov/">Login.gov portal</a> application's configuration. All urls that users could be redirected to, even as a passthrough, need to be included in the list of Redirect URLs. |
There was a problem hiding this comment.
Question: outside of the scope of this ticket, but "Login.gov portal" seems... wrong, and it looks like we keep using that in various places. Some of these instances should probably be renamed to "Partner Portal", and others may need to be rephrased. @nickttng thoughts?
There was a problem hiding this comment.
@mmagsa Agreed - "Login.gov portal" looks wrong. In this case it should be either:
- "Redirect URLs field in the Login.gov Partner Portal ..."
- "Redirect URLs field in the portal ..."
Based on our content guidelines, it should be either "Partner Portal" (When needing to be formal) or "portal" (When it's okay to be informal).
There was a problem hiding this comment.
This is pretty small, there are 6 instances across 3 pages. Should we go with Partner Portal, since the original is somewhat formal, as "Login.gov portal"?
There was a problem hiding this comment.
I will say there is at least one spot where "Login.gov Partner Portal" makes sense because it is in context with other portals (ie, 'MS Power Apps Portal')
There was a problem hiding this comment.
ok, check out the new commit. I can always roll it back or edit it further.
There was a problem hiding this comment.
"Partner Portal" as a standalone makes sense when it's clear on what it's talking about 👍🏼
nickttng
left a comment
nickttng
left a comment
There was a problem hiding this comment.
The newer commits look good to me.
Dev-Docs #11
Make sure that all instances of "Partner Portal" are capitalized, and other general instances of "portal" are lowercase.