Fix: Remove unused TokenSale feature #729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llision Remove the entire TokenSale feature which was unused and caused a composite-key namespace collision (H-06) with TokenSwapFill - both used INDEX_KEY = "GCTSF". This removal also makes L-01 (missing time range validation in createTokenSale) and L-02 not applicable since the feature no longer exists. Files removed: - chaincode/src/sales/ (entire folder - 9 files) - chain-api/src/types/sale.ts Files modified: - chaincode/src/index.ts (removed sales export) - chain-api/src/types/index.ts (removed sale export) - chaincode/src/__test__/GalaChainTokenContract.ts (removed TokenSale contract methods)
dzikowski
approved these changes
Dec 12, 2025
dzikowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removal also makes L-01 (missing time range validation in createTokenSale) and L-02 not applicable since the feature no longer exists.
Files removed:
Files modified: