Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 14, 2024

Description of proposed changes

Split pygmt/tests/test_clib_virtualfiles.py into:

  • pygmt/tests/test_clib_inquire_virtualfile.py
  • pygmt/tests/test_clib_virtualfile_from_matrix.py
  • pygmt/tests/test_clib_virtualfile_from_stringio.py
  • pygmt/tests/test_clib_virtualfile_from_vectors.py
  • pygmt/tests/test_clib_virtualfile_in.py

Note that open_virtualfile tests remain in test_clib_virtualfiles.py.

Addresses #3351 (comment).

Previous split at #2784.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Oct 14, 2024
@seisman seisman added this to the 0.14.0 milestone Oct 14, 2024
@weiji14 weiji14 added the run/benchmark Trigger the benchmark workflow in PRs label Oct 14, 2024
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #3512 will not alter performance

Comparing tests/split (4ce69d8) with main (f224563)

Summary

✅ 93 untouched benchmarks

🆕 8 new benchmarks
⁉️ 8 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main tests/split Change
🆕 test_open_virtualfile N/A 62.7 ms N/A
🆕 test_virtualfile_from_matrix N/A 63.3 ms N/A
🆕 test_virtualfile_from_vectors N/A 63.9 ms N/A
🆕 test_virtualfile_from_vectors_one_string_or_object_column[object] N/A 8.4 ms N/A
🆕 test_virtualfile_from_vectors_one_string_or_object_column[str] N/A 8.4 ms N/A
🆕 test_virtualfile_in_required_z_matrix[DataFrame-vector] N/A 9.6 ms N/A
🆕 test_virtualfile_in_required_z_matrix[Dataset-vector] N/A 11.9 ms N/A
🆕 test_virtualfile_in_required_z_matrix[array-matrix] N/A 9 ms N/A
⁉️ test_virtual_file 63 ms N/A N/A
⁉️ test_virtualfile_from_matrix 63.3 ms N/A N/A
⁉️ test_virtualfile_from_vectors 64 ms N/A N/A
⁉️ test_virtualfile_from_vectors_one_string_or_object_column[object] 8.4 ms N/A N/A
⁉️ test_virtualfile_from_vectors_one_string_or_object_column[str] 8.4 ms N/A N/A
⁉️ test_virtualfile_in_required_z_matrix[DataFrame-vector] 9.6 ms N/A N/A
⁉️ test_virtualfile_in_required_z_matrix[Dataset-vector] 11.9 ms N/A N/A
⁉️ test_virtualfile_in_required_z_matrix[array-matrix] 9 ms N/A N/A

@weiji14 weiji14 removed the run/benchmark Trigger the benchmark workflow in PRs label Oct 14, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep test_inquire_virtualfile in test_clib_virtualfiles.py? I'd like to keep that file so that we can still look back at the git history more easily.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've renamed test_clib_open_virtualfiles.py back to test_clib_virtualfiles.py.

For inquire_virtualfile, I plan to add more tests about GMT_IN in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that works too, thanks!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 14, 2024
@seisman seisman merged commit 86c9b2d into main Oct 14, 2024
18 checks passed
@seisman seisman deleted the tests/split branch October 14, 2024 23:02
weiji14 added a commit that referenced this pull request Nov 15, 2024
The test_virtualfile_from_vectors_one_string_or_object_column unit test was moved to test_clib_virtualfile_from_vectors.py. Xref #3512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants