Skip to content

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 14, 2025

Description of proposed changes

Because why not have more failing Windows tests 😆

References:

Similar to #3778 but for Windows

Preview:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Apr 14, 2025
@weiji14 weiji14 added this to the 0.16.0 milestone Apr 14, 2025
@weiji14 weiji14 self-assigned this Apr 14, 2025
@weiji14 weiji14 marked this pull request as ready for review April 14, 2025 23:56
@weiji14 weiji14 marked this pull request as draft April 14, 2025 23:59
@weiji14
Copy link
Member Author

weiji14 commented Apr 15, 2025

Getting an error on the setup-micromamba step at https://github.com/GenericMappingTools/pygmt/actions/runs/14458118336/job/40545485415?pr=3911:

Error: Unsupported platform: win32-arm64

I see that only win_arm64 as supported at https://github.com/mamba-org/mamba/blob/64a620a2aa046d7508a302a06d63f49425b48b7b/libmamba/include/mamba/specs/platform.hpp#L42 from mamba-org/mamba#2745. Maybe something needs to change on mamba, or the GitHub Actions runner. Edit: actually, probably need an extra entry here - https://github.com/mamba-org/setup-micromamba/blob/d17c2171caa36ec145ac7e4658406a66d9af236d/src/util.ts#L24-L31

@seisman seisman removed this from the 0.16.0 milestone Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants