Figure.timestamp: Refactor to use the new alias system #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
changed the title
seisman
force-pushed
the
refactor/timestamp
branch
from
f31ab3c to
a2989b9
Compare
seisman
changed the title
seisman
force-pushed
the
refactor/timestamp
branch
2 times, most recently
from
c305455 to
2f442fe
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Figure.timestamp method to use PyGMT's new alias system instead of the previous manual argument building approach. The refactor simplifies the code by leveraging structured alias definitions for parameter handling.
- Replaces manual dictionary building and string concatenation with the new
AliasSystemandAliasclasses - Improves error message clarity for the
textparameter length validation - Consolidates GMT version compatibility workarounds with better documentation
seisman
force-pushed
the
refactor/timestamp
branch
3 times, most recently
from
e818b30 to
d78c9ff
Compare
seisman
force-pushed
the
refactor/timestamp
branch
from
d78c9ff to
a038b80
Compare
seisman
added
final review call
seisman
changed the title
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new alias system, the
Figure.timestampmethod can be simplified.