Skip to content

Conversation

@duyifanict
Copy link
Contributor

sloved #285

@duyifanict duyifanict requested a review from Copilot November 4, 2025 02:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a smoke test for the DLinear model along with a minimal test dataset and updates the CI workflow to support running these tests.

  • Adds smoke test for DLinear model (test_dlinear_smoke_test)
  • Introduces ETTh1_mini dataset for testing (train/val/test splits with timestamps)
  • Updates GitHub Actions workflow to install PyTorch and run all pytest tests
  • Removes obsolete test files (run_all_test.py and test_launcher.py)

Reviewed Changes

Copilot reviewed 5 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/smoke_test/test_dlinear.py New smoke test for DLinear model using ETTh1_mini dataset
tests/smoke_test/datasets/ETTh1_mini/*.npy Binary NumPy files containing test data and timestamps
tests/smoke_test/datasets/ETTh1_mini/meta.json Metadata configuration for the ETTh1_mini dataset
.gitignore Updated to explicitly include test dataset files
.github/workflows/python-test.yml Added PyTorch installation and removed pytest ignore flag
tests/run_all_test.py Removed obsolete test runner
tests/basicts_test/test_launcher.py Removed empty test placeholder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"MAE",
"MSE"
],
"null_val": NaN
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid JSON syntax: NaN is not a valid JSON value. It should be either null, a number, a string like \"NaN\", or removed if not needed. JSON parsers will fail to parse this file.

Suggested change
"null_val": NaN
"null_val": null

Copilot uses AI. Check for mistakes.
run: |
python -m pip install --upgrade pip
pip install flake8 pytest
pip install torch torchvision --index-url https://download.pytorch.org/whl/cpu
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation of torchvision appears unnecessary for this test suite as the smoke test only imports and uses PyTorch core functionality. Consider removing torchvision to reduce installation time and dependencies.

Suggested change
pip install torch torchvision --index-url https://download.pytorch.org/whl/cpu
pip install torch --index-url https://download.pytorch.org/whl/cpu

Copilot uses AI. Check for mistakes.
@duyifanict duyifanict merged commit a0b56e1 into GestaltCogTeam:master Nov 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant