Deprecate AttachmentType.LINK and fix link styling not applied in MessageReplyView.
#5848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2025 14:01
SDK Size Comparison 📏
|
VelikovPetar
commented
Jun 25, 2025
...n/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/view/MessageReplyView.kt
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates AttachmentType.LINK and its related utility, and fixes a bug where link styling in MessageReplyView was not applied. Key changes include:
- Deprecating AttachmentType.LINK and Attachment.isLink() in core, client, and documentation.
- Fixing link detection in MessageReplyView by updating the check logic.
- Introducing a createIntent method in AttachmentActivity to avoid hard-coded extras.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/navigation/destinations/AttachmentDestination.kt | Replaced hard-coded intent creation with AttachmentActivity.createIntent. |
| stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/viewholder/attachment/UnsupportedAttachmentFactory.kt | Removed deprecated AttachmentType.LINK from the supported attachment types. |
| stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/view/MessageReplyView.kt | Updated link detection logic to correctly identify link attachments and apply styling. |
| stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/gallery/AttachmentActivity.kt | Added a companion object with createIntent, replacing the use of hard-coded string keys. |
| stream-chat-android-components/api/stream-chat-android-ui-components.api | Updated API definitions to include the new createIntent method. |
| stream-chat-android-core/src/main/java/io/getstream/chat/android/models/AttachmentType.kt | Marked AttachmentType.LINK as deprecated with updated documentation. |
| stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/attachment/AttachmentUtils.kt | Deprecated isLink(), with a note about its returning false. |
| DEPRECATIONS.md | Documented the deprecation of AttachmentType.LINK and Attachment.isLink(). |
| CHANGELOG.md | Updated changelog with deprecation and link styling fix information. |
...n/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/view/MessageReplyView.kt
Outdated
Show resolved
Hide resolved
andremion
reviewed
Jul 2, 2025
...n/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/view/MessageReplyView.kt
Outdated
Show resolved
Hide resolved
|
andremion
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Resolves: https://linear.app/stream/issue/AND-605/remove-deprecate-attachmenttypelink-from-android-sdk
The attachment type
linkis not an officially supported (see: https://getstream.io/chat/docs/android/message_format/#attachment-format and https://getstream.io/chat/docs/android/message_format/#open-graph-scraper). Exposing theAttachmentType.LINKas a public type can be confusing for customers, because it gives a false impression that links are a separate type of attachment. Because we cannot delete this directly, it is just deprecated for the moment, and to be removed in an upcoming release.Additionally, this PR fixes a bug where the link styling (
MessageReplyStyle.linkBackgroundColorMine/MessageReplyStyle.linkBackgroundColorTheirs/MessageReplyStyle.linkStyleMine/MessageReplyStyle.linkStyleTheirs) is not applied (because the current checks for isLink() were always returning false).🛠 Implementation details
AttachmentType.LINK(Note: currently there is only one usage remaining ofAttachmentType.LINKin theAttachmentDestination- but its internal and not directly linked to theAttachmentclass)Attachment.isLink()isLink()check inMessageReplyViewto correctly check if the message has a link (currently it always returnsfalse)createIntentmethod for theAttachmentActivityto avoid using hard-coded argument keys.🎨 UI Changes
🧪 Testing