unit tests for addReply function #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR checklist ❌The following issues were detected:
What we check
|
gpunto
reviewed
Oct 16, 2025
| threadedCommentData(id = "parent-1", replies = listOf(originalComment), replyCount = 1) | ||
| val updated = parent.addReply(newComment, comparator) | ||
|
|
||
| // Then: since comparator sorts descending, originalComment should come first |
There was a problem hiding this comment.
We aren't specifying createdAt for either originalComment or newComment, so we're not really testing the sorting here, right?
There was a problem hiding this comment.
updated this, sorting,append and increment are tested together under one roof
Comment on lines
130
to
131
| @Test | ||
| fun `addReply should append reply and increment replyCount`() { |
There was a problem hiding this comment.
Do we need this test? The behavior it's testing is already covered by the test below.
| // Given | ||
| val comparator = | ||
| Comparator<CommentsSortDataFields> { a, b -> | ||
| // Reverse sort for demonstration |
There was a problem hiding this comment.
Suggested change
| // Reverse sort for demonstration | |
| // Reverse sort for demonstration |
| val newComment = threadedCommentData(id = "comment-2", parentId = "parent-1") | ||
| val parent = | ||
| threadedCommentData(id = "parent-1", replies = listOf(originalComment), replyCount = 1) | ||
| val updated = parent.addReply(newComment, comparator) |
There was a problem hiding this comment.
To be consistent with other tests in this file
Suggested change
| val updated = parent.addReply(newComment, comparator) | |
| // When | |
| val updated = parent.addReply(newComment, comparator) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add unit tests for the
addReplyfunction to ensure it correctly appends replies and updates the replyCount, while maintaining the order of repliesImplementation
Created two test cases for the
addReplyTesting
Ran unit tests to confirm:
replyCount is correctly incremented.
The replies list contains the new reply.
Replies are sorted correctly according to the comparator.
Checklist