-
Notifications
You must be signed in to change notification settings - Fork 1
Use new built-in story feeds in the sample #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements built-in story feeds support by adding new feed types (stories
for viewing followed users' stories and story
for posting user's own stories) and modifying the story viewing experience to support aggregated story display with watch tracking functionality.
- Added support for built-in story feed types and story watching functionality
- Updated story UI to display aggregated stories with navigation controls and watch indicators
- Modified feed structure to separate timeline and story feeds with proper following relationships
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
Feeds.kt | Added new feed type functions for stories and story feeds |
StoryScreen.kt | Enhanced story viewing with multi-story navigation and watch tracking |
ProfileViewModel.kt | Updated to use new state structure and follow story feeds when following users |
ProfileScreen.kt | Updated to access feed data through new state structure |
FeedsScreen.kt | Modified stories display to use aggregated activities and watch indicators |
FeedViewModel.kt | Refactored to support separate timeline and story feeds with watch functionality |
TestData.kt | Added isWatched field to test activity data |
ActivityOperations.kt | Added isWatched field mapping from response |
ActivityData.kt | Added isWatched property to activity data model |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...am-feeds-android-sample/src/main/java/io/getstream/feeds/android/sample/story/StoryScreen.kt
Show resolved
Hide resolved
...m-feeds-android-sample/src/main/java/io/getstream/feeds/android/sample/feed/FeedViewModel.kt
Show resolved
Hide resolved
...s-android-client/src/main/kotlin/io/getstream/feeds/android/client/api/model/ActivityData.kt
Show resolved
Hide resolved
...s-android-sample/src/main/java/io/getstream/feeds/android/sample/profile/ProfileViewModel.kt
Outdated
Show resolved
Hide resolved
...m-feeds-android-sample/src/main/java/io/getstream/feeds/android/sample/feed/FeedViewModel.kt
Show resolved
Hide resolved
* Handle FeedCreatedEvent * Move Feed filter check to FeedEventHandler * Rename filter parameter to activityFilter * Remove FeedAdded handling for Feed
|
Goal
AND-840
We now have backend support for built-in story feeds:
stories
: kinda equivalent totimeline
, i.e. where a user sees all the stories of users they followstory
: kinda equivalent touser
, i.e. where a user posts their own storiesDocs
Implementation
stories:user_id
and post user stories tostory:user_id
Testing
Launch the sample, create/view stories
Checklist