Skip to content

Conversation

amosgyamfi
Copy link
Member

Image previews for the Expo TikTok sample app.

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, thanks a lot !

However I would honestly try to record these on a device rather than on a simulator/emulator. The reason for this is the fact that under the hood we utilize FlashList, for which this particular usecase is sort of the bread and butter of its capabilities.

With that said, in debug builds it tends to perform more poorly due to how recycling works in general. In other words it should look and feel much, much better for a demo such as this one (that flicker on Android should be gone). This is fine for now but it would be great if we could do it at some point too.

Also, the new post creation screen appears to have more stuff in it than the app has currently, were these added after the fact ? I don't think we should be adding things that do not exist yet.

And one final question, should we maintain these gifs/previews as the app changes ? Since it's a sample app, it will change significantly and very quickly, I'm sure. Not an issue to do it at all, just wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants